Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released Ruby gem is missing LICENSE file. #292

Open
jackorp opened this issue Mar 25, 2024 · 1 comment
Open

Released Ruby gem is missing LICENSE file. #292

jackorp opened this issue Mar 25, 2024 · 1 comment
Labels
🐛 bug Defect / Bug

Comments

@jackorp
Copy link
Contributor

jackorp commented Mar 25, 2024

I am working on updating a few packages in the Ruby cucumber stack in Fedora and I noticed the license file is missing from this library now, that wasn't the case with v14.

From what I understand the file should be present in the released gem as it's a copy of the software.

Not 100% sure how a proper fix should look like.

AFAICT, to build and then unpack/install the gem properly, the license has to be either on the same level with the .gemspec file in the Ruby gem or some level below. A file cannot be referenced a level up from gemspec, so doing something like s.files << "../LICENSE" is not going to work for unpacking the gem. Perhaps a Rakefile target that copies the LICENSE first and then builds the gem so that something like s.files << "./LICENSE" would then be OK.

@jackorp jackorp added the 🐛 bug Defect / Bug label Mar 25, 2024
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Mar 25, 2024

Ah. That would have been my fault. I deduplicated the licenses in #195 and in other repos as well. We probably have this problem in quite a few projects then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
Status: No status
Development

No branches or pull requests

2 participants