Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot release version after pre-release #98

Open
luke-hill opened this issue Nov 1, 2023 · 3 comments
Open

Cannot release version after pre-release #98

luke-hill opened this issue Nov 1, 2023 · 3 comments

Comments

@luke-hill
Copy link

πŸ‘“ What did you see?

[15:41:39] luke@luke-ubuntu:~/Code/cucumber-rails$ polyglot-release 3.0.0
Version 3.0.0 has already been released.

βœ… What did you expect to see?

polyglot-release working for cucumber-rails (3.0.0.rc1 is released)

πŸ“¦ Which tool/library version are you using?

polyglot-release latest

πŸ”¬ How could we reproduce it?

Try run polyglot-release

Steps to reproduce the behavior:

  1. Install '...' version '...'
  2. Create a file called '....'
  3. Run command '....'
  4. See error '....'

πŸ“š Any additional context?


This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje
Copy link
Contributor

I suspect this check

if [ -n "$(git tag --list "v$NEW_VERSION")" ]; then
echo "Version $NEW_VERSION has already been released."
exit 1
fi
also matched the 3.0.0-rc1 tag.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 1, 2023

No. It does not.

mpkorstanje@nyx:~/Projects/cucumber/cucumber-jvm$ git tag --list  | head
v1.0.0
v1.0.0-RC3
v1.0.0.RC1
v1.0.0.RC10
v1.0.0.RC11
v1.0.0.RC12
v1.0.0.RC13
v1.0.0.RC14
v1.0.0.RC15
v1.0.0.RC16
mpkorstanje@nyx:~/Projects/cucumber/cucumber-jvm$ git tag --list  v1.0.0
v1.0.0

@luke-hill could you check this with your git version?

Otherwise the only alternative I can think of is that you already had a 3.0.0 tag locally. And that you've deleted it when creating the latest release manually.

@luke-hill
Copy link
Author

That didn't show that tag.

But I did the manual release like you showed me before. Making the changelog commit and version commit by hand, then pushing to main then making a new branch and pushing to that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants