No Parameter highlighting in VSCode Light/Dark Mode

[kiran-epic]

👓 What did you see?

When using VSCode in light /dark theme mode, the step parameters are not highlighted at all. The highlighting works when using other themes like light+/dark+

✅ What did you expect to see?

The parameter should be highlighted making it easier to identify

📦 Which tool/library version are you using?

Extension Version : 1.2.8
Extension Settings :

{
    "cucumber.features": [
        "cypress/e2e/features/**/*.feature"
    ],
    "cucumber.glue": [
        "cypress/e2e/step_definitions/**/*.ts"
    ]
}

🔬 How could we reproduce it?

Steps to reproduce the behavior:

1. Install the extension & configure it such that the step definitions are available for the extension to parse the steps
2. Switch the Visual Studio Theme (Code -> Preferences -> Color Theme ->Light (Visual Studio)

Light Mode (Visual Studio)

Dark Mode (Visual Studio)

📚 Any additional context?

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[aslakhellesoy]

We use the parameter semantic token type to highlight parameters. It is also referenced in the docs

It appears that some VSCode themes don't have a style for this token type. For example:

• Dark (Visual Studio) - no styling of param
• Dark+ (default dark) - has styling of param

We need to study the semantic highlight guide and syntax highlight guide more closely to get to the bottom of this I think.

The scope inspector might also help.

[nklowns]

Mine Dark+ (default dark) dont highlight

How can I help debugging this?

[cortexcompiler]

I was not getting syntax highlighting in some of my Dark mode color themes and this comment fixed it for me through the addition of this setting:

    "[cucumber]": {
        "editor.semanticHighlighting.enabled": true
    },

[kieran-ryan]

Glad this resolved the issue for you @cortexcompiler and appreciate you contributing that mitigation.

Have raised a PR so that the extension enables semantic highlighting by default for gherkin, so modifying configuration depending on colour theme will not be required.

Would you be able to provide the names of some colour themes where you experienced the issued and the configuration resolved? Would like to test against them to ensure properly resolves the issue in your case. A quick try of the above configuration with 'GitHub Dark' and 'GitHub Light' did not appear to work for me - though the '+' versions of both work without configuration; interested if works for you, and what version of VSCode you are using?