Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating most.js in cyclejs/most-run to @most/core #845

Open
kanitsharma opened this issue Sep 24, 2018 · 8 comments
Open

Updating most.js in cyclejs/most-run to @most/core #845

kanitsharma opened this issue Sep 24, 2018 · 8 comments
Labels
help wanted priority 2 (could) scope: run size S

Comments

@kanitsharma
Copy link

@most/core is pretty stable right now and even encouraged by the people at most.js to be used in new projects.

image

plus it provides curried API and a tree shakable package which would be awesome to have 馃槃
@jleider
Copy link

jleider commented Dec 4, 2018

I second this, are there any possible updates?

@IssueHuntBot
Copy link

@staltz has funded $40.00 to this issue. See it on IssueHunt

@jvanbruegge
Copy link
Member

I had a look at this, but @most/core feels still very alpha. There are barely any operators, for example the important from operator is completely missing

janat08 added a commit to janat08/cyclejs that referenced this issue Mar 24, 2019
@janat08
most-run to support @most/core
149b8d9 
cyclejs#845
@janat08 janat08 mentioned this issue Mar 24, 2019
Closed
@janat08
Copy link

janat08 commented Mar 24, 2019 •
edited

Using @most/create since it's backwards compatible I changed adapt and added test to see if @most/core actually runs. It didn't run. The sinks are converted to xs with fromObservable method.

  1) run()
       supports mostjs core, the foundation for version 2:
     TypeError: this.ins.subscribe is not a function
      at FromObservable._start (node_modules/xstream/src/index.ts:134:26)
... /home/jk/development/cyclejs/most-run/node_modules/@cycle/run/src/internals.ts:98:43

janat08 added a commit to janat08/cyclejs that referenced this issue Mar 30, 2019
@janat08
most-run to support @most/core
1566a53 
cyclejs#845
test


done
janat08 added a commit to janat08/cyclejs that referenced this issue Mar 30, 2019
@janat08
most-run to support @most/core
6aaac6f 
cyclejs#845
Uses @most/create that isn't officially supported, I imagine in terms of it handling simultaneously @Most and mostjs with it's backwards compatibility. Untested since it relies  on run to support unadapt.
janat08 added a commit to janat08/cyclejs that referenced this issue Mar 30, 2019
@janat08
most-run to support @most/core
a03da03 
feat(most-run): uses @most/create that isn't officially supported. Is backwards compatible.

Uses @most/create that isn't officially supported, I imagine in terms of it handling simultaneously
@Most and mostjs with it's backwards compatibility. Untested since it relies  on run to support
unadapt, a method replace xs.fromPromise in run to support @Most. Doesn't add tests to run, making
sure that drivers actually get proper sources. There're some warning in most@ as to how custom
stream creators should be made, which I just assume create package respects as the warning's meaning
was beyond me.

BREAKING CHANGE:
none

ISSUES CLOSED: cyclejs#845
@janat08 janat08 mentioned this issue Mar 30, 2019
Closed
@FbN
Copy link

FbN commented May 5, 2019

I have draft an implementation 369b140
Seems to work on a Hello World app, I suspect it need to better manager errors.
Does anyone can help on writing tests?

FbN added a commit to FbN/cyclejs that referenced this issue Jun 15, 2019
@FbN
feat(most-run): the Cycle run() function to be used with @most/core.
b9dbf06 
ISSUES CLOSED: cyclejs#845
@kanitsharma
Copy link
Author

kanitsharma commented Feb 7, 2020 •
edited

Hey guys, would love to know the status on this.

@staltz
Copy link
Member

staltz commented Feb 7, 2020

I believe that @jvanbruegge and I are focusing on the next version of Cycle.js which will affect/change/deprecate most-run and this issue would be solved through a different way.

@ftaiolivista
Copy link

I believe that @jvanbruegge and I are focusing on the next version of Cycle.js which will affect/change/deprecate most-run and this issue would be solved through a different way.

WOW.... If I can help in some way =))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted priority 2 (could) scope: run size S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: most-run to support @most/core janat08/cyclejs
8 participants
@jleider @staltz @ftaiolivista @FbN @jvanbruegge @janat08 @kanitsharma @IssueHuntBot