Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsx-seconds-elapse example doesn't compiles #936

Open
beenotung opened this issue Mar 31, 2020 · 0 comments
Open

tsx-seconds-elapse example doesn't compiles #936

beenotung opened this issue Mar 31, 2020 · 0 comments

Comments

@beenotung
Copy link

beenotung commented Mar 31, 2020

Code to reproduce the issue:

git clone https://github.com/cyclejs/cyclejs
cd cyclejs/examples/intermediate/tsx-seconds-elapsed
npm start

Expected behavior:
It should compile the code, without error.

Actual behavior:
The compile failed with below error:

...
mkdirp dist && tsc

node_modules/@types/react/index.d.ts(77,26): error TS1005: ',' expected.
node_modules/@types/react/index.d.ts(77,28): error TS1005: '>' expected.
node_modules/@types/react/index.d.ts(77,30): error TS1005: ';' expected.
node_modules/@types/react/index.d.ts(77,32): error TS1109: Expression expected.
node_modules/@types/react/index.d.ts(77,52): error TS1005: '(' expected.
...

Workarond:
Although the error is caused by mis-configuration of the build process for typescript, the error can be ignored to continue the build, and the built code works well.
Therefore, in the npm script, if I add || true after tsc, it will allow browserify to continue the build process.

Versions of packages used:
master branch (15.4.0)

@beenotung beenotung changed the title tsx-seconds-elapse doesn't compiles tsx-seconds-elapse example doesn't compiles Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant