Re-enable autoreset of colour in terminal

[MetRonnie]

Problem

The scheduler log would get a spurious color reset char (ESC[0m) at the start of the "DONE" line when not in no-detach mode.

This was being caused by autoreset=True being passed to

cylc-flow/cylc/flow/terminal.py

Lines 269 to 270 in 9abced9

	# configure Cylc to use colour
	color_init(autoreset=True, strip=not use_color)

and some weird interaction with the scheduler daemonization process. The "DONE" line in the log is the only line logged by scheduler_cli after the scheduler has finished running:

cylc-flow/cylc/flow/scheduler_cli.py

Lines 443 to 445 in 9abced9

	LOG.info("DONE")
	close_log(LOG)
	sys.exit(ret)

Proposed Solution

Note

autoreset was set to False in:

• Fix terminal/log color issues #6021

Ideally we want autoreset to be set to True to ensure we don't permanently colour the terminal output by mistake. This will take some figuring out to achieve without getting the spurious reset character again.

I expect with more careful file handing around the daemonization it wouldn't happen (it shouldn't logically), e.g. close logs in the original process and re-open them in the fork?

#6021 (comment)