Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eventemitter2 and vite deps #23740

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Sep 9, 2022

  • Closes n/a

User facing changelog

n/a

Additional details

  • lock eventemitter2 version to fix failing CI test (todo-mvc-firefox)
  • update vite and remove patch-package

Steps to test

CI should pass, ALL steps, especially test-binary-against-todomvc-firefox and the other binary ones.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 9, 2022

Thanks for taking the time to open a PR!

@@ -38,7 +38,7 @@
"dayjs": "^1.10.4",
"debug": "^4.3.2",
"enquirer": "^2.3.6",
"eventemitter2": "^6.4.3",
"eventemitter2": "6.4.7",
Copy link
Contributor Author

@lmiller1990 lmiller1990 Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing CI to fail, example.

6.4.8 has a breaking change for types. I locked to 6.4.7 for now. Because we did ^6.4.3 before (notice ^) we got the highest 6.4.x.

They've got an open issue: EventEmitter2/EventEmitter2#292

@@ -65,7 +65,7 @@
"shiki": "^0.9.12",
"unplugin-icons": "0.13.2",
"unplugin-vue-components": "^0.15.4",
"vite": "3.0.3",
"vite": "3.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this so we can remove the patch package we had for 3.0.3.

@lmiller1990 lmiller1990 changed the title chore: deps chore: update eventemitter2 and vite deps Sep 9, 2022
@lmiller1990 lmiller1990 marked this pull request as ready for review September 9, 2022 04:10
@cypress
Copy link

cypress bot commented Sep 9, 2022



Test summary

40028 0 3346 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 9c902a2
Started Sep 9, 2022 5:22 AM
Ended Sep 9, 2022 5:38 AM
Duration 15:18 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/connectors.cy.ts Flakiness
1 cy.origin connectors > .each()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@emilyrohrbough emilyrohrbough merged commit 23d52af into develop Sep 9, 2022
@emilyrohrbough emilyrohrbough deleted the fix-ci-deps branch September 9, 2022 13:14
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2022

Released in 10.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants