-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update eventemitter2 and vite deps #23740
Conversation
Thanks for taking the time to open a PR!
|
@@ -38,7 +38,7 @@ | |||
"dayjs": "^1.10.4", | |||
"debug": "^4.3.2", | |||
"enquirer": "^2.3.6", | |||
"eventemitter2": "^6.4.3", | |||
"eventemitter2": "6.4.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing CI to fail, example.
6.4.8 has a breaking change for types. I locked to 6.4.7 for now. Because we did ^6.4.3
before (notice ^
) we got the highest 6.4.x
.
They've got an open issue: EventEmitter2/EventEmitter2#292
@@ -65,7 +65,7 @@ | |||
"shiki": "^0.9.12", | |||
"unplugin-icons": "0.13.2", | |||
"unplugin-vue-components": "^0.15.4", | |||
"vite": "3.0.3", | |||
"vite": "3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this so we can remove the patch package we had for 3.0.3.
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
n/a
Additional details
Steps to test
CI should pass, ALL steps, especially
test-binary-against-todomvc-firefox
and the other binary ones.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?