Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between code and doc regarding traps _sigwatch and _sigunwatch #105

Closed
aktiur opened this issue Nov 12, 2016 · 2 comments
Closed

Comments

@aktiur
Copy link

aktiur commented Nov 12, 2016

As the documentation says, kernel traps come in two flavors: regular, or synchronous.
From what I could understand from the code, synchronous traps are implemented by calling ready_appendleft when handling the trap to make sure the current task is rescheduled immediately without another task getting executed in the middle.

Both _sigwatch and _sigunwatch are said in the docs to be synchronous. However, they are implemented in the kernel, using _reschedule_task, allowing another task to get resumed.

@aktiur
Copy link
Author

aktiur commented Nov 12, 2016

I had not seen @njsmith issue #101 / pull request #103 which may render this specific issue moot. Having a look right now.

@aktiur
Copy link
Author

aktiur commented Nov 12, 2016

Not a problem anymore with the new implementation of synchronous traps.

@aktiur aktiur closed this as completed Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant