Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Replace Jaeger with generic OTLP Export #1952

Closed
austinlparker opened this issue Mar 31, 2022 · 5 comments
Closed

✨ Replace Jaeger with generic OTLP Export #1952

austinlparker opened this issue Mar 31, 2022 · 5 comments

Comments

@austinlparker
Copy link

What are you trying to do?

Rather than exporting to Jaeger directly, why not output OTLP over gRPC/HTTP in order to support trace data export in a more 'pure' format that can go to the OTel Collector or directly to a tracing system that supports OTLP ingest?

Why is this important to you?

No response

How are you currently working around this?

I did a local rip/replace of the Jaeger exporter with "go.opentelemetry.io/otel/exporters/otlp/otlptrace" and it seems to work fine going to a local collector. Obviously, someone could also use a Jaeger receiver on the collector and transform the trace data that way, but I just thought it'd be neat to skip that step. I'm not sure if there's a reason that Jaeger is being used in the first place other than convenience?

@austinlparker
Copy link
Author

It looks like everything works in terms of the trace itself, maybe there's stuff in buildkit that's looking for Jaeger to export to, I admit I didn't do a ton of research on how all of these parts work together
Screen Shot 2022-03-30 at 9 56 44 PM
.

@jlongtine
Copy link
Contributor

I like this idea. I suspect the original reason for setting this up this way was simply to keep it straightforward so we could just run buildkitd and jaeger as shown here: https://github.com/dagger/dagger/blob/main/tracing.compose.yaml

Seems like we could pretty easily change the code to OTLP export, change the compose file to include an OTel collector that forwarded to Jaeger (or another trace system).

@austinlparker
Copy link
Author

If you'd like, I can change up the compose file and submit a PR? Probably next week.

@jlongtine
Copy link
Contributor

@austinlparker That'd be great! I'll keep an eye out for your PR (and feel free to @ me!).

@jedevc
Copy link
Member

jedevc commented May 1, 2024

Hiya, closing this issue out since this is an old one - a lot of our architecture has changed in the meantime, we're now focused on language SDKs instead of CUE 🎉

However, we've recently added support for more complex OTEL support, there's a lot more information in #6835 about exactly how that works - so I think that should possibly actually resolve the original idea in this issue?

If I've misunderstood, no worries we can re-open! 🎉

@jedevc jedevc closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants