Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset is calculated wrong in a certain case #230

Open
rramaa opened this issue Oct 13, 2019 · 0 comments · May be fixed by #231
Open

Offset is calculated wrong in a certain case #230

rramaa opened this issue Oct 13, 2019 · 0 comments · May be fixed by #231

Comments

@rramaa
Copy link

rramaa commented Oct 13, 2019

Describe the bug
When there is a lot of difference between the parentNode and the scroll Element, then the offset is calculated incorrectly. The space between the parentNode and the scroll Element is not taken into account

Expected behavior
The space between the parentNode and the scroll Element should be taken into account

Happens on every browser
rramaa added a commit to rramaa/react-infinite-scroller that referenced this issue Oct 13, 2019
@rramaa
Added correct calculation of offset
3d73903 
Fixes danbovey#230
@rramaa rramaa linked a pull request Oct 13, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added correct calculation of offset rramaa/react-infinite-scroller
1 participant
@rramaa