Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onError callback instead of throwing error #27

Open
camdarley opened this issue Mar 29, 2022 · 0 comments
Open

Add onError callback instead of throwing error #27

camdarley opened this issue Mar 29, 2022 · 0 comments

Comments

@camdarley
Copy link

Hi,
The React img component has an onError callback in case there's something wrong with image src.
Would it be possible to provide the same callback in the Spritesheet component?
Currently, Spritesheet throw an error:

 imgLoadSprite.onerror = () => {
      throw new Error(`Failed to load image ${imgLoadSprite.src}`);
 };

could be replaced by:

 imgLoadSprite.onerror = () => {
      onError(`Failed to load image ${imgLoadSprite.src}`);
 };

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant