-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some GUI proposal for the script manager #438
Comments
I'm not convinced with the color :) What about just making the background as "selected" button on dt interface? |
More thoughts.... Changed the color to shades of gray to show on/off I also added an image option to button so that I can do a box with a button on the left and a label on the right
that looks like this... the problem being that the box isn't fixed size and my GTK CSS skills suck :) |
Oh yes, I love this last version. It fits really well into darktable GUI. I really think that the Lua plug-ins should be more first class citizen and we should put effort on making it more integrated. So there is the GUI, hence my proposal here and the translation. The fact that there is no translation make some label in English and all lower case in the now capitalized French UI (and of course this is true for all languages I suppose). What can we do to improve this? (maybe need another issue to discuss this). |
For Lua being a first class citizen, I'd propose the following:
or That is, the section ( So maybe we need a structured way to describe a modules (like dt modules) and have the Lua manager use the same layout. In dt each IOP give a set of strings but the layout is done by dt. For example in
Maybe something similar would work too for Lua. For the translation, I'm not sure yet but maybe if we set the lua Git repository as sub-project we can use the main dt translation support also for Lua. Would that be ok with you? I can experiment and see if it works. |
@wpferguson : For the translation, how to tell the Lua scripts to look for the darktable |
The way I get the current tooltip is by grabbing the comments at the start of the file and using a regular expression to pull out the description. I've thought about using a table to organize the information, but in order to access the table I'd have to run the script. I just had a thought to see if there is a way to load the script without running it which might make the data available. I'd like to keep the scripts self documenting if at all possible. |
I figured out a way to get the data from the script. I can create a code snippet in the file like
I can grab that out of the script and write it to a temporary file, then import it using |
Got the button interface working. Figured out how to pass the description
I'm using user.css to hold the css. Should I add it to the themes? |
Actually closed by #479 |
The current script manager looks like:
I find it hard to read each line and do proper separation between the script name and the status.
A proposal would be to left align the script name and right align the status and possibly use some symbol for started / stopped.
The text was updated successfully, but these errors were encountered: