Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Ids #1

Open
Crystark opened this issue Aug 24, 2010 · 2 comments
Open

Using Ids #1

Crystark opened this issue Aug 24, 2010 · 2 comments

Comments

@Crystark
Copy link

Hi,

I was trying to implement your ProgressBar. Great work though i was wondering : why are you using ids for each part of the ProgressBar ? Using a class names and accessing the objects using container.getElement('.myclass') would work perfectly and you wouldn't have to define ids for each loader you wana set on a page.

For instance, if i want to create two loaders and i don't want to bother defining ids for each, then your script is going to set the same id for each bar. I know i could just define the ids, but when doing group work, you never know what id has already been used so i try avoiding them.

I'm not an expert so if i'm wrong, do not hesitate to correct me.

Anyway, thanks for this great tool !

@darkwing
Copy link
Owner

Good point! I created this class a long time ago so that's why it's like that. I'll update to use classes very soon, unless you have an update ready to send.

Thank you!

@Crystark
Copy link
Author

Nop, i've yet only needed it once in a page.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants