Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from Virgil Pierce #583

Open
ivelasq opened this issue Mar 28, 2024 · 0 comments
Open

Feedback from Virgil Pierce #583

ivelasq opened this issue Mar 28, 2024 · 0 comments
Labels
feedback General feedback general corrections Fixes need to writing and code.

Comments

@ivelasq
Copy link
Collaborator

ivelasq commented Mar 28, 2024

Feedback from Virgil Pierce:

  • In the online version of the book you use view() in this chapter, in the print version we bought you use View(); either the user will need to set view <- View or they need to switch to View.

  • The bar charts plotted in this chapter use a default lexicographic ordering of the horizontal axis. For both features plotted a different ordering provides more information and questions for the data. The students worked out that these can be changed by passing the relevant column through the ordered command with a list of the levels in the column in the preferred order (A+, A, A-, etc).

  • One of our students is very colorblind and so we have been adjusting the colors in the plots as we go using the ColorBrewer package. In this chapter we were a little puzzled by the choice to fill the first bar plot and ultimately decided we preferred it with no color; in the second bar plot the color really has no meaning and so we redid that one with a solid color (no fill).

@restrellado restrellado added feedback General feedback general corrections Fixes need to writing and code. labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback General feedback general corrections Fixes need to writing and code.
Projects
None yet
Development

No branches or pull requests

2 participants