Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

index.html and check.py don't agree on country format #45

Open
dleehr opened this issue Mar 10, 2017 · 1 comment
Open

index.html and check.py don't agree on country format #45

dleehr opened this issue Mar 10, 2017 · 1 comment

Comments

@dleehr
Copy link

dleehr commented Mar 10, 2017

The comment in the index.html front matter prescribes a 2-letter lowercase country name:

country: "FIXME"      # country (lowercase two-letter ISO code such as "fr" - see https://en.wikipedia.org/wiki/ISO_3166-1)

But the check.py script expects the country to be a hyphenated full name:

COUNTRIES = [
    'Abkhazia', 'Afghanistan', 'Aland', 'Albania', 'Algeria',
    'American-Samoa', 'Andorra', 'Angola', 'Anguilla',
...
def check_country(country):
    '''"country" must be a hyphenated full country name from the list
    embedded in this script.'''

    return country in COUNTRIES

I'm happy to make the change but not sure which is preferred.

@dleehr
Copy link
Author

dleehr commented Mar 10, 2017

Ah, I see this is fixed in #36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant