Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DNStateManager to use Persistable and drop generics #376

Open
andyjefferson opened this issue May 6, 2021 · 0 comments
Open

Change DNStateManager to use Persistable and drop generics #376

andyjefferson opened this issue May 6, 2021 · 0 comments
Labels
enhancement unresourced

Comments

@andyjefferson
Copy link
Member

andyjefferson commented May 6, 2021 •
edited

The generics option would have allowed us to permit enhancement to other contracts (e.g JDO reference bytecode), but the absence of people on this project mean that will never happen, so let's simplify it all. Likely will impact on API calls down into store plugins, so has a major impact. Wait for 6.0

Other classes involved
ExecutionContext
CachedPC
StateManagerFactory
StateManagerImpl
@andyjefferson andyjefferson added this to the 6.0.0.m1 milestone May 6, 2021
andyjefferson added a commit that referenced this issue May 7, 2021
@andyjefferson
Drop generics from CachedPC. For #376
d79a425
andyjefferson added a commit that referenced this issue May 7, 2021
@andyjefferson
Change method signatures for cache to return Persistable as object type.
838737f 
For #376
andyjefferson added a commit that referenced this issue May 7, 2021
@andyjefferson
Change return type of some findObjectXXX methods to be Persistable
d8ba899 
instead of Object. For #376
@andyjefferson andyjefferson modified the milestones: 6.0.0.m1, 6.0.0.release May 26, 2021
@andyjefferson andyjefferson changed the title Change ObjectProvider to use Persistable and drop generics Change DNStateManager to use Persistable and drop generics Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement unresourced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyjefferson