Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds.dataFrameSubset keep.cols / rm.cols parameter should accept character vectors? #297

Open
tombisho opened this issue Nov 11, 2020 · 3 comments

Comments

@tombisho
Copy link
Contributor

Reviewing the ds-helper package, a function is provided to return the index of a column in a dataframe, because ds.dataFrameSubset requires this for the keep.cols/rm.cols parameter.

It would be easier if ds.dataFrameSubset would accept the column name, because then this helper function would not be needed?

@davraam
Copy link
Member

davraam commented Nov 11, 2020

Yes we should modify the ds.dataFrameSubset to accept column names. This is important when the order of the columns is not the same across the different studies.

@tombisho
Copy link
Contributor Author

That's a good point, I hadn't thought of that!

@tombisho
Copy link
Contributor Author

Just to revisit this issue, one of our analysts is saying that the removal of ds.subset (where you can use column names) will cause a major issue because the columns are in different orders in each study. So I think ds.subset cannot be removed until this feature is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants