Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds.mean(), ds.var() fail on nfilter for a variable that is NA #387

Open
tombisho opened this issue Jul 16, 2021 · 2 comments
Open

ds.mean(), ds.var() fail on nfilter for a variable that is NA #387

tombisho opened this issue Jul 16, 2021 · 2 comments

Comments

@tombisho
Copy link
Contributor

tombisho commented Jul 16, 2021

If a variable is completely NA then ds.mean() and ds.var() return the error:

Nvalid less than nfilter.tab

and the call fails. I am not sure that is the right behaviour because that is confusing for the analyst, perhaps they should return NA and not fail?

@StuartWheater
Copy link
Member

So the suggested behavior would be:

  • Column all NA returns: indication "all NA"
  • Column non-NA above 1 but below nfilter.tab returns: indicates disclosure issue.
  • Column non-NA above nfilter.tab: return results.

This seem sensible, but I will seek advice.

Stuart

@tombisho
Copy link
Contributor Author

Yes I think your answer is more complete than mine 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants