Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minified version of vendor libraries #317

Closed
johnglover opened this issue Feb 12, 2013 · 6 comments
Closed

Add minified version of vendor libraries #317

johnglover opened this issue Feb 12, 2013 · 6 comments
Assignees

Comments

@johnglover
Copy link
Contributor

Some of the 3rd party library directories also contain minified versions and others do not. We should add the official minimised releases for all versions where possible with the extension .min.[js/css], and try to minimise ourselves if no minimised versions are available.

This will hopefully fix issues such as not being able to minimise Recline's current version of bootstrap with certain (well used) minimisers (see: twbs/bootstrap#3057).

@ghost ghost assigned johnglover Feb 12, 2013
@rufuspollock
Copy link
Member

IMO we should not have minified versions in recline. If we do have minified I'd prefer to have non-minified ...

@johnglover
Copy link
Contributor Author

We would also have non-minified (used by default), but currently anyone deploying Recline has to go hunting for minified versions of every 3rd party library or rely on minifying everything themselves (which is error prone). Some minified versions are already in the repository (eg: backbone).

@rufuspollock
Copy link
Member

Not sure I agree. I'd imagine people would minify in one go in their app (using uglify etc).

They may already be using some of the components (e.g. jquery) for other parts of their app and will want to build there not here.

@johnglover
Copy link
Contributor Author

They would still be able to do that though, I don't think we lose anything by including them, no one is forced to use them. On the other hand it's quite a pain that some of them are missing.

@rufuspollock
Copy link
Member

Right, but it bloats the repo and means we now have both the source and the minified version of each library. As yet I don't see a compelling argument for having minified in this repo but I could be wrong :-)

Perhaps we could do a summary pros / cons in the main description :-) and then decide ...

@johnglover
Copy link
Contributor Author

Ok we'll put it on hold for now if you're not keen on it, we're doing this for CKAN anyway so can copy things across at a later date if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants