Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: failed to install TiShadow, issue with package nan #484

Open
hannta opened this issue Apr 8, 2016 · 1 comment
Open

Windows: failed to install TiShadow, issue with package nan #484

hannta opened this issue Apr 8, 2016 · 1 comment

Comments

@hannta
Copy link

hannta commented Apr 8, 2016

I tried to install TiShadow to my Win10, got the following error:

C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\nan.h(409): error C2039: 'ExternalAsciiStringResource': is not a member of 'v8::String' [C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\build\bufferutil.vcxproj]
 C:\Users\user\.node-gyp\4.3.1\include\node\v8.h(2081): note: see declaration of 'v8::String'
C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\node_modules\nan\nan.h(409): error C2065: 'ExternalAsciiStringResource': undeclared identifier [C:\Users\user\AppData\Roaming\npm\node_modules\tishadow\node_modules\socket.io\node_modules\socket.io-client\node_modules\ws\build\bufferutil.vcxproj]

TiShadow uses pretty old socket.io and socket.io-client which has issues with ws \ nan packages.
More info: socketio/engine.io-client#376 & socketio/socket.io#2057

I managed to fix this updating ws packages as mentioned here, but I think TiShadow should update socket.io packages.

@dbankier
Copy link
Owner

dbankier commented Apr 9, 2016

@hannta, since you've done the work already, I'm happy for a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants