Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge picture&foaf:description, pictureDescription&depictionDescription #85

Open
VladimirAlexiev opened this issue Jun 8, 2016 · 2 comments

Comments

@VladimirAlexiev
Copy link
Member

The following prop pairs mean the same, so merge them:

  • picture&foaf:description
  • pictureDescription&depictionDescription

I think "picture" is used more often, but needs to be checked.

In addition, check the usage of imageSize. It could just be deleted, since all (most?) images are now on Commons, and commons metadata is emitted standardly for all media (no mapping needed).

@jimkont
Copy link
Member

jimkont commented Jun 8, 2016

mapping images actually doesn't work atm and we use the ImageExtractor for this.
so both dbo:picture and foaf:depiction doesn't do anything

however, iirc foaf:depiction is used by the framework for the image extractor and cannot be deleted while dbo:picture can

@VladimirAlexiev
Copy link
Member Author

I agree: one is objectProperty the other is dataProperty, but neither makes an image URL correctly.

  • Does the ImageExtractor also extract caption and imageSize?
  • How about different kinds of images: image, signature, coatOfArms, map... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants