Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

props distanceToLondon etc are crazy #98

Open
VladimirAlexiev opened this issue Jul 24, 2017 · 2 comments
Open

props distanceToLondon etc are crazy #98

VladimirAlexiev opened this issue Jul 24, 2017 · 2 comments

Comments

@VladimirAlexiev
Copy link
Member

@maxjakob has made the following atrocity in http://mappings.dbpedia.org/index.php?title=Mapping_en:Infobox_German_state&action=submit:

	{{PropertyMapping | templateProperty = belfast_distance_km | ontologyProperty = distanceToBelfast | unit = kilometre }}
	{{PropertyMapping | templateProperty = cardiff_distance_km | ontologyProperty = distanceToCardiff | unit = kilometre }}
	{{PropertyMapping | templateProperty = edinburgh_distance_km | ontologyProperty = distanceToEdinburgh | unit = kilometre }}
	{{PropertyMapping | templateProperty = london_distance_km | ontologyProperty = distanceToLondon | unit = kilometre }}
	{{PropertyMapping | templateProperty = douglas_distance_km | ontologyProperty = distanceToDouglas | unit = kilometre }}

Why is it an atrocity? Because creating properties that have a specific city in their name is just crazy. Instead we need a separate node that describes the distance between two constant cities: the current resource and the one named in the template property.

It was probably not his fault since the first commit says "copy of Infobox German State but state un-capitalized". Unfortunately the mapping framework is not modular, so any such mistake is copied many times over by different people.

distanceToBelfast is used 6 times. Searching for distanceto* returns 5 such flawed props that are used in 8 templates, but the list is not complete (the mapping wiki search is defective).

@phil294
Copy link

phil294 commented Dec 16, 2019

Shouldnt GeocoordinatesMapping be enough? Why add a new prop that is merely computed?

@VladimirAlexiev
Copy link
Member Author

Maybe they state road distance not air distance, so cannot be computed.
But I agree such props are marginally useful, it's much better to ask a map/routing service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants