Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with thor 0.19.2 dependency #653

Closed
kenaniah opened this issue Nov 27, 2016 · 3 comments
Closed

Incompatible with thor 0.19.2 dependency #653

kenaniah opened this issue Nov 27, 2016 · 3 comments

Comments

@kenaniah
Copy link

kenaniah commented Nov 27, 2016

After upgrading to thor-0.19.2 from thor-0.19.1, the following issue is takes place when running foreman:

/.../lib/ruby/gems/2.3.0/gems/thor-0.19.2/lib/thor/base.rb:534:in `thor_reserved_word?': "run" is a Thor reserved word and cannot be defined as command (RuntimeError)
	from /.../lib/ruby/gems/2.3.0/gems/thor-0.19.2/lib/thor/base.rb:597:in `method_added'
	from /.../lib/ruby/gems/2.3.0/gems/foreman-0.82.0/lib/foreman/cli.rb:80:in `<class:CLI>'
	from /.../lib/ruby/gems/2.3.0/gems/foreman-0.82.0/lib/foreman/cli.rb:11:in `<top (required)>'
	from /.../lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in `require'
	from /.../lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in `require'
	from /.../lib/ruby/gems/2.3.0/gems/foreman-0.82.0/bin/foreman:5:in `<top (required)>'
	from /.../bin/foreman:23:in `load'
	from /.../bin/foreman:23:in `<main>'

Everything works perfectly with thor-0.19.1 and below.

@stevenleeg
Copy link

I've been seeing this issue as well with a fresh rails inited project

Here's my Procfile:

web: bundle exec rails s

Running foreman start gives the same error as above.

@MrChrisW
Copy link

This is fixed in rails/thor@329cff6 and released in Thor 0.19.4

@kenaniah
Copy link
Author

Indeed, fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants