Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stockfish 6 #8

Closed
ornicar opened this issue Jan 28, 2015 · 4 comments · Fixed by #9
Closed

stockfish 6 #8

ornicar opened this issue Jan 28, 2015 · 4 comments · Fixed by #9
Assignees

Comments

@ornicar
Copy link

ornicar commented Jan 28, 2015

A new version of stockfish is out! How difficult would it be to upgrade this fork? I honestly have no idea.

@ddugovic
Copy link
Owner

I think it shouldn't be difficult; I've been trying to reconstitute my development environment (I'm migrating and upgrading my development server) for the past month and I'm getting close to a point where I can do this!

I think it's just a matter of pulling/merging changes from the master repo; there's a merge conflict so I need to do the pull/merge on a development machine and then sync GitHub with that machine. I've tried to do this pull/merge before and found command-line git confusing, but in theory it should be simple...

@apetresc
Copy link

Hey guys, I went ahead and did the merge on my fork.

There were some tricky parts to the merge conflicts, but in all cases, I looked at the git blame where @ddugovic had made the original change to figure out the intent, and did the sensible thing (I think).

Everything seems to work correctly, although I don't know how to test lichess KOTH-functionality specifically.

Hopefully this makes your jobs a bit easier :)

@ddugovic
Copy link
Owner

Excellent!! I'll test out your fork tonight and very likely pull your changes! :)

It now occurs to me that the simplest regression test would be to play against itself (SF5 versus SF6) via an interface such as XBoard or Arena Chess Interface! I look forward to doing that!

@ddugovic ddugovic self-assigned this Jan 29, 2015
@ddugovic
Copy link
Owner

Thus far I've confirmed that with @apetresc's latest changes, Stockfish recognizes the game end condition. I'll review the code changes to ensure things look sane, then pull the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants