Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR videos are too bright #924

Open
deckerst opened this issue Feb 25, 2024 · 2 comments
Open

HDR videos are too bright #924

deckerst opened this issue Feb 25, 2024 · 2 comments
Labels
P2 random bugs & feature requests type:feature New feature or request video

Comments

@deckerst
Copy link
Owner

          I don't know if it's related but HDR videos of the pixel 8 pro look super bright - to the point that it looks very bad - on Aves, when compared to the Google Photos app where they look normal.

Example video if it helps looking at the metadata or something: https://nc.djf.lol/s/SYnoFxLKRb2tPbF

Originally posted by @davidfrickert in #838 (comment)

@deckerst
Copy link
Owner Author

In Google Photos, I can see when switching to the HDR video a quick transition from "too bright" to tone-mapped:

I tried different players on the same frame (more or less).

Aves (too bright)

MPV (classic renderer)

MPV (future renderer)

Google Photos

Aves uses for video playback the media_kit package, which uses MPV, and we can see Aves and classic MPV rendering is basically the same, but there's hope with the future MPV renderer. Colors are not as deep as with Google Photos rendering, but it's a big improvement. I'll try and see whether I can switch to it.

@deckerst deckerst added type:feature New feature or request P2 random bugs & feature requests video labels Feb 26, 2024
@davidfrickert
Copy link

Already a nice improvement! From digging around it seems that both Flutter and MPV don't have native support for HDR so they probably map into SDR which could explain the less dark colors even in the "future renderer"? But eh I have no idea about any of this stuff.

flutter/flutter#91241
media-kit/media-kit#615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 random bugs & feature requests type:feature New feature or request video
Projects
None yet
Development

No branches or pull requests

2 participants