Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some checks from TrainTestValidationSuite don't show up in wandb #2605

Open
michaelwang1994-olo opened this issue Jun 16, 2023 · 1 comment
Labels
bug linear needs triage Issue needs to be labeled and prioritized

Comments

@michaelwang1994-olo
Copy link

Describe the bug
I ran a TrainTestValidationSuite on my data and when I do `.to_wandb(project='...'), I am missing the following checks in my wandb run charts:

  1. NewCategoryTrainTest
  2. StringMismatchComparison
  3. DatasetsSizeComparison --> This shows up under "Train Test Validation Suite/None"

See screenshot for all the Train Test Validation Suite checks that do show up in the run.

To Reproduce
Steps to reproduce the behavior:

train_ds = Dataset(
        df_train,
        label=label,
        index_name=index_name,
        datetime_name=datetime_name,
        cat_features=cat_features
    )
test_ds = Dataset(
    df_test,
    label=label,
    index_name=index_name,
    datetime_name=datetime_name,
    cat_features=cat_features
)
validation_suite = train_test_validation(
    timeout=timeout
)
validation_results = validation_suite.run(train_ds, test_ds)
validation_results.to_wandb(project=wandb.run.project)

Expected behavior
I would have expected all the checks from the suite to show up and be correctly named.

Screenshots
image

Environment (please complete the following information):

  • OS: MacOS Ventura 13.4
  • Python Version: 3.11.3
  • Deepchecks Version: 0.17.3

Additional context

@github-actions github-actions bot added needs triage Issue needs to be labeled and prioritized linear labels Jun 16, 2023
@noamzbr
Copy link
Collaborator

noamzbr commented Jun 18, 2023

Thanks for reporting @michaelwang1994-olo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linear needs triage Issue needs to be labeled and prioritized
Projects
None yet
Development

No branches or pull requests

2 participants