Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreation of binaries on file changes in make file #2484

Open
AustinAbro321 opened this issue May 8, 2024 · 0 comments
Open

Recreation of binaries on file changes in make file #2484

AustinAbro321 opened this issue May 8, 2024 · 0 comments
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@AustinAbro321
Copy link
Contributor

Describe what should be investigated or refactored

Currently the make file builds lots of binaries needed for end to end tests. Instead of rebuilding binaries or zarf packages on each subsequent run we simply check if they are there. This saves time but can lead to testing on old binaries or packages if they have changed. It would be better if we dynamically recreated binaries or packages within make if anything changed.
For example:

  • any go code changes should lead to re-build on make
  • any changes to the init package or zarf agent should lead to a rebuild of the init package on make init-package
  • any change to any of the example packages should lead to rebuild - ideally this could be done dynamically but if that's not doable I still believe hard coding the paths is worth it.
@AustinAbro321 AustinAbro321 added the tech-debt 💳 Debt that the team has charged and needs to repay label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Status: No status
Development

No branches or pull requests

1 participant