Commit 554c03c2e432340293afd56d56cb26a80f3e336b to defunkt's facebox

defunkt / facebox

this repo is viewable by everyone

Description:	Facebook-style lightbox, built in jQuery
Homepage:	http://famspam.com/facebox/
Clone URL:	git://github.com/defunkt/facebox.git Give this clone URL to anyone. `git clone git://github.com/defunkt/facebox.git`

Click here to lend your support to: facebox and make a donation at www.pledgie.com !

width is now set dynamically

defunkt (author)

about 1 month ago

commit 554c03c2e432340293afd56d56cb26a80f3e336b
tree b9aaa7f56498dcd3ee8e32efad7c6b91a73ed6e0
parent 16c6542a0475179215a1667cd505960f1913dc3d

facebox.js

facebox.js

0
@@ -125,8 +125,6 @@
1
         left:  385.5
2
       }).show()
1
 
12
-      $('#facebox').css('left', $(window).width() / 2 - ($('#facebox table').width() / 2))
1
-
1
       $(document).bind('keydown.facebox', function(e) {
2
         if (e.keyCode == 27) $.facebox.close()
1
         return true

Comments

defunkt about 1 month ago at facebox.js L128

If we’re going to set the location dynamically, we need to do it after the content has loaded.
vanpelt about 1 month ago at facebox.js L128

Great point defunkt! Also if you’re going to show off your new code commenting feature you need to make more ridiculous comments like this one :)
gtcaz about 1 month ago at facebox.js L132

So true.
jnewland about 1 month ago at facebox.js L127

so, do these comments stick around until this chunk of whitespace is removed?
anildigital about 1 month ago at facebox.js L128

Nice feature
drnic about 1 month ago

Iz in ur codez commentun
drnic about 1 month ago at facebox.js L131

27 is a "magic number" and should be given a pretty name
bjeanes about 1 month ago at facebox.js L131

oh yes …. very magic O_o
kamal about 1 month ago

Ah, but the beauty of the original github source code view let you highlight ranges. I can see where that can get pretty complicated with the comment count chicklet – would you have to nest it if the comment did span multiple lines? :)
rsanheim about 1 month ago at facebox.js L130

huh uh huh. you said bind.
carlosbrando about 1 month ago

Test
carlosbrando about 1 month ago at facebox.js L125

Very good!
myabc about 1 month ago at facebox.js L129

Fantastic.. This is my favourite line.
(goodbye email).
ngage about 1 month ago at facebox.js L126

Oh! Oh! First! :P
bdude about 1 month ago at facebox.js L126

I love your use of brackets here, very in right now.
jorrel about 1 month ago

so, up to how many comments will be shown here? Is this paginated? I guess lets keep adding comments to find out.
randy about 1 month ago at facebox.js L128

How many comments can be added to line of code? 9? Should we find out?
randy about 1 month ago at facebox.js L128

5
randy about 1 month ago at facebox.js L128

6
randy about 1 month ago at facebox.js L128

7
randy about 1 month ago at facebox.js L128

8
randy about 1 month ago at facebox.js L128

9
randy about 1 month ago at facebox.js L128

10 uh oh! Let’s see what happens :-)
randy about 1 month ago at facebox.js L128

Nice.
grobie about 1 month ago at facebox.js L128

12