Skip to content

Commit

Permalink
width is now set dynamically
Browse files Browse the repository at this point in the history
  • Loading branch information
@defunkt
defunkt committed Apr 10, 2008
1 parent 16c6542 commit 554c03c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions facebox.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@
left: 385.5

This comment has been minimized.

Sign in to view

Copy link
@carlosbrando

carlosbrando Apr 11, 2008

Very good!

This comment has been minimized.

Sign in to view

Copy link
@kyv

kyv Aug 13, 2012

hola

This comment has been minimized.

Sign in to view

Copy link
@knoxilla

knoxilla Oct 9, 2014

Another

This comment has been minimized.

Sign in to view

Copy link
@knoxilla

knoxilla Oct 9, 2014

And another

This comment has been minimized.

Sign in to view

Copy link
@haxta4ok00

haxta4ok00 Sep 28, 2016

This comment has been minimized.

Sign in to view

Copy link
@haxta4ok00

haxta4ok00 Sep 28, 2016

This comment has been minimized.

Sign in to view

Copy link
@jxltom

jxltom Feb 9, 2017

Nice

This comment has been minimized.

Sign in to view

Copy link
@jpurple

jpurple May 2, 2017

quite right

This comment has been minimized.

Sign in to view

Copy link
@kimwoods

kimwoods Feb 11, 2020

gsrg

This comment has been minimized.

Sign in to view

Copy link
@meweez

meweez Jun 26, 2021

test

This comment has been minimized.

Sign in to view

Copy link
@vhaarscher

vhaarscher Aug 18, 2021

test

This comment has been minimized.

Sign in to view

Copy link
@knightsamar

knightsamar Dec 2, 2021

this is acomment
}).show()

This comment has been minimized.

Sign in to view

Copy link
@lackstein

lackstein Apr 11, 2008

Oh! Oh! First! :P

This comment has been minimized.

Sign in to view

Copy link
@margaridaCF

margaridaCF Mar 21, 2018

.hide()

This comment has been minimized.

Sign in to view

Copy link
@cotyembry

cotyembry May 3, 2018

.toggle()

This comment has been minimized.

Sign in to view

Copy link
@jnewland

jnewland Apr 10, 2008

so, do these comments stick around until this chunk of whitespace is removed?

This comment has been minimized.

Sign in to view

Copy link
@jpurple

jpurple May 2, 2017

9 years and counting

This comment has been minimized.

Sign in to view

Copy link
@TalBigel

TalBigel Jul 22, 2017

Comment

This comment has been minimized.

Sign in to view

Copy link
@passionfruit18

passionfruit18 Nov 30, 2020 •
edited
Loading

@jnewland If the whitespace is removed, that will be in a future commit... this commit will stay untouched...
$('#facebox').css('left', $(window).width() / 2 - ($('#facebox table').width() / 2))

This comment has been minimized.

Sign in to view

Copy link
@defunkt

defunkt Apr 10, 2008

Author Owner

If we’re going to set the location dynamically, we need to do it after the content has loaded.

This comment has been minimized.

Sign in to view

Copy link
@vanpelt

vanpelt Apr 10, 2008

Great point defunkt! Also if you’re going to show off your new code commenting feature you need to make more ridiculous comments like this one :)

This comment has been minimized.

Sign in to view

Copy link
@anildigital

anildigital Apr 10, 2008

Nice feature

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

How many comments can be added to line of code? 9? Should we find out?

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

5

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

6

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

7

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

8

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

9

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

10 uh oh! Let’s see what happens :-)

This comment has been minimized.

Sign in to view

Copy link
@r38y

r38y Apr 13, 2008

Nice.

This comment has been minimized.

Sign in to view

Copy link
@grobie

grobie Apr 14, 2008

12

This comment has been minimized.

Sign in to view

Copy link
@timgut

timgut Jan 16, 2009

13

This comment has been minimized.

Sign in to view

Copy link
@copacetic

copacetic Mar 3, 2017

Hello world :!

This comment has been minimized.

Sign in to view

Copy link
@pipe01

pipe01 Apr 11, 2018

15

This comment has been minimized.

Sign in to view

Copy link
@dnhn

dnhn Aug 21, 2023

If we’re going to set the location dynamically, we need to do it after the content has loaded.

Agree.

This comment has been minimized.

Sign in to view

Copy link
@HoraceShmorace

HoraceShmorace Jun 20, 2024

Smort.
image

This comment has been minimized.

Sign in to view

Copy link
@myabc

myabc Apr 11, 2008

Fantastic.. This is my favourite line.

Fantastic.. This is my favourite line.(goodbye email).

This comment has been minimized.

Sign in to view

Copy link
@arikan

arikan Jul 5, 2008

comment on white space
$(document).bind('keydown.facebox', function(e) {

This comment has been minimized.

Sign in to view

Copy link
@rsanheim

rsanheim Apr 11, 2008

huh uh huh. you said bind.
if (e.keyCode == 27) $.facebox.close()

This comment has been minimized.

Sign in to view

Copy link
@drnic

drnic Apr 10, 2008

27 is a “magic number” and should be given a pretty name

This comment has been minimized.

Sign in to view

Copy link
@bjeanes

bjeanes Apr 11, 2008

oh yes …. very magic O_o
return true

This comment has been minimized.

Sign in to view

Copy link
@4rc0s

4rc0s Apr 10, 2008

So true.

This comment has been minimized.

Sign in to view

Copy link
@jackystan

jackystan Nov 16, 2009

What does "true" indicate?

This comment has been minimized.

Sign in to view

Copy link
@ruarcs

ruarcs Mar 28, 2013

Test.

This comment has been minimized.

Sign in to view

Copy link
@ilam

ilam Jun 24, 2014

Testing the comment on line. Cool 👍

This comment has been minimized.

Sign in to view

Copy link
@lauriys

lauriys via email Jun 24, 2014

This comment has been minimized.

Sign in to view

Copy link
@renuka-fernando

renuka-fernando Dec 5, 2020

Yes!!!
Expand Down

14 comments on commit 554c03c

@drnic
Copy link

@drnic drnic commented on 554c03c Apr 10, 2008

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iz in ur codez commentun

@kamal
Copy link
Contributor

@kamal kamal commented on 554c03c Apr 11, 2008

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but the beauty of the original github source code view let you highlight ranges. I can see where that can get pretty complicated with the comment count chicklet – would you have to nest it if the comment did span multiple lines? :)

@carlosbrando
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@jorrel
Copy link

@jorrel jorrel commented on 554c03c Apr 13, 2008

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, up to how many comments will be shown here? Is this paginated? I guess lets keep adding comments to find out.

@Aureole
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just test

@AnarManafov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@lauriys
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did i get here

@micahbolen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

554c03c

@amaybaum
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@digi0ps
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy 10th birthday Github. 🎉

@benmiller314
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: do we need permissions to write comments?

@benmiller314
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: do we need permissions to write comments?

Either we don't, or this one is set to be open to everyone...

@winstontsai
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI

@senseispice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit

Please sign in to comment.