Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for upgrading git packages #142

Open
cldwalker opened this issue Aug 25, 2010 · 2 comments
Open

Fix for upgrading git packages #142

cldwalker opened this issue Aug 25, 2010 · 2 comments

Comments

@cldwalker
Copy link
Contributor

Branch for the fix with tests. Also fixes upgrading gist packages. Perhaps the fix belongs in uninstall so that install/uninstall can be the same for git/gist packages?

@josh
Copy link
Contributor

josh commented Aug 25, 2010

I think this is really a bug with looking up packages by name in the current environment. I think you mentioned you had a rip-find-package somwhere? I'd be great if that command would work with git short names, full urls, or local package paths.

Another issue I've hit with upgrading is when it fails because the new package doesn't exist. Instead of using install, we should prefetch with rip-package, uninstall, then import that new package.

@cldwalker
Copy link
Contributor Author

Updated branch. Ended up making find_package a helper since the uninstall message also needs a package object, something an executable can't give us.

As for upgrading a non-existant, adding a rip-package didn't work since rip-uninstall still aborted. However, removing $-e worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants