Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failures on both 1.8 and 1.9 #1

Closed
Flameeyes opened this issue Feb 14, 2010 · 5 comments
Closed

test failures on both 1.8 and 1.9 #1

Flameeyes opened this issue Feb 14, 2010 · 5 comments

Comments

@Flameeyes
Copy link 

flame@yamato gibbler % sergeant 
 History                                                                        

  Basics 
   "can convert short digest into long"                                  PASS
   "can return most recent stamp"                                        PASS
   "can return history"                                                  PASS
   "can return history (short)"                                          PASS

  Hash History 
   "Setup Hash class"                                                    PASS
   "doesn't reveal self.__gibbler_history instance variable"             PASS
   "can take a Hash snapshot"                                            PASS
   "return a Hash history"                                               PASS
   "can revert Hash"                                                     PASS
   "knows a valid gibble"                                                PASS
   "knows an invalid gibble"                                             PASS
   "can revert to any valid gibble"                                      PASS
   "revert does nothing if digest is the same as current one"            PASS
   "can revert using short gibble"                                       PASS

  String History 
   "Setup String class"                                                  PASS
   "can take a String snapshot"                                          PASS
   "return a String history"                                             PASS
   "can revert String"                                                   PASS

  Arbitrary Object History 
   "Setup String class"                                                  PASS
   "can take a FullHouse snapshot"                                       PASS
   "return a FullHouse history"                                          FAIL 
   "can revert FullHouse"                                                PASS

  "return a FullHouse history"                                           1/1   
      failed: ["4192d4cb59975813f117a51dcd4454ac16df6703", "05219bdee8ec6300b579f2ba8ce55d851d10928b"] == ["4192d4cb59975813f117a51dcd4454ac16df6703", "2c6957aa1e734d2a3a71caf569a7461a3bf26f11"]
       drill: ["4192d4cb59975813f117a51dcd4454ac16df6703", "05219bdee8ec6300b579f2ba8ce55d851d10928b"]
       dream: ["4192d4cb59975813f117a51dcd4454ac16df6703", "2c6957aa1e734d2a3a71caf569a7461a3bf26f11"]


  Exceptions 
   "raises exception when reverting to unknown gibble"                   PASS
   "raises exception when reverting and there's no history"              PASS
   "raises exception when reverting an unsupported object"               PASS

  Array History 
   "Setup Array class"                                                   PASS
   "can take a Array snapshot"                                           PASS
   "return an Array history"                                             PASS
   "can revert Array"                                                    PASS

 Gibbler Gazette                                                                

  URI object tryouts 
   "URI::HTTP can gibbler"                                               PASS
   "URI::HTTPS can gibbler"                                              PASS
   "URI::HTTP is trailing slash sensitive"                               PASS
   "URI::Generic can gibbler"                                            PASS
   "URI::FTP can gibbler"                                                PASS

  Time tryouts 
   "Date instance can gibbler"                                           PASS
   "Time instance can gibbler"                                           PASS
   "Time instance can gibbler with single digit values"                  PASS
   "DateTime instance can gibbler"                                       PASS
   "Time digest is based on UTC"                                         PASS
   "DateTime digest is based on UTC"                                     PASS

  Basic syntax with SHA256 
   "A Symbol can gibbler"                                                PASS
   "Class can gibbler"                                                   PASS
   "TrueClass can gibbler"                                               PASS
   "Empty Hash instance"                                                 PASS

  Extended object tryouts 
   "true can gibbler"                                                    PASS
   "false can gibbler"                                                   PASS
   "TrueClass can gibbler"                                               PASS
   "FalseClass can gibbler"                                              PASS
   "Class can gibbler"                                                   PASS
   "Object can gibbler"                                                  PASS
   "Class instance can gibbler"                                          PASS
   "Module can gibbler"                                                  PASS
   "Module instance can gibbler"                                         PASS
   "Proc can gibbler"                                                    PASS
   "Range instance (..) can gibbler"                                     PASS
   "Range instance (...) can gibbler"                                    PASS
   "Range (..) doesn't equal range (...)"                                PASS
   "nil has a gibbler"                                                   PASS
   "Module can gibbler"                                                  PASS
   "Module instance can gibbler"                                         PASS
   "Class can gibbler"                                                   PASS

  Proc 
   "Proc.new can gibbler"                                                PASS
   "Proc can gibbler"                                                    PASS
   "proc can gibbler"                                                    PASS
   "lambda can gibbler"                                                  PASS
   "lambda gibbler is not aware of arity"                                PASS
   "proc gibbler is not aware of arity"                                  PASS
   "Proc gibbler is not aware of proc payload"                           PASS
   "MyProc has a different digest"                                       PASS

  Basic syntax with SHA1 
   "include Gibbler raises exception"                                    PASS
   "Symbol can gibbler"                                                  PASS
   "String can gibbler"                                                  PASS
   "String and Symbol return different digests"                          PASS
   "Class can gibbler"                                                   PASS
   "Empty Hash instance"                                                 PASS
   "Fixnum instance"                                                     PASS
   "Bignum instance"                                                     PASS
   "Populated Hash instance"                                             PASS
   "Empty Array instance"                                                PASS
   "Populated Array instance"                                            PASS
   "Knows when a Hash has not changed"                                   PASS
   "Knows when a Hash has changed"                                       PASS
   "Symbols digests don't cross streams"                                 PASS
   "String digests don't cross streams"                                  PASS
   "Symbol has list of attic vars"                                       PASS
   "String has list of attic vars"                                       FAIL 
   "Hash has list of attic vars"                                         FAIL 
   "Freezing an object will update the digest"                           PASS
   "works on arbitrary objects"                                          FAIL 
   "doesn't reveal @__gibbler_digest__ instance variable"                PASS
   "previous digest"                                                     PASS

  "String has list of attic vars"                                        1/3   
      failed: [:gibbler_cache, :__gibbler_history] == [:gibbler_cache]
       drill: [:gibbler_cache, :__gibbler_history]
       dream: [:gibbler_cache]


  "Hash has list of attic vars"                                          2/3   
      failed: [:gibbler_cache, :__gibbler_history] == [:gibbler_cache]
       drill: [:gibbler_cache, :__gibbler_history]
       dream: [:gibbler_cache]


  "works on arbitrary objects"                                           3/3   
      failed: #<FullHouse:0x7ff06a3dfe20 @roles=[:jesse, :joey, :danny, :kimmy, :michelle, :dj, :stephanie]>.gibbler == "6ea546919dc4caa2bab69799b71d48810a1b48fa"
       drill: "fa5f741275b6b27932537e1946042b0286286e1d"
       dream: "6ea546919dc4caa2bab69799b71d48810a1b48fa"


  File object tryouts 
   "File can gibbler"                                                    FAIL 
   "Gibbler is different for each path"                                  FAIL 
   "TempFile can gibbler"                                                PASS
   "TempFile digests change"                                             PASS
   "File doesn't care about file contents"                               PASS

  "File can gibbler"                                                     1/2   
      failed: #<File:/media/repos/flame/ruby/gibbler/CHANGES.txt>.gibbler == "33027386bd95e91efc4711648d488519062d828f"
       drill: "d5b2b0ac570bf7ac3aa1ca7e3d905b325de31671"
       dream: "33027386bd95e91efc4711648d488519062d828f"


  "Gibbler is different for each path"                                   2/2   
      failed: #<File:/media/repos/flame/ruby/gibbler/README.rdoc>.gibbler == "4c131b7e5f9e7b841b4501d2d002785d3730ae19"
       drill: "6b84d8790e02fdea14dc46ef3f5fdcc1da6e392b"
       dream: "4c131b7e5f9e7b841b4501d2d002785d3730ae19"


 Mixins                                                                         

  String 
   "has String#clear"                                                    PASS

 Performance                                                                    

  Speed 
   "Setup variables"                                                     PASS
   "Array#hash"                                                          PASS
   "Array#gibbler"                                                       PASS
   "Hash#hash"                                                           PASS
   "Hash#gibbler"                                                        PASS

  Uniqueness 
   "Array#hash, all unique"                                              PASS
   "Hash#hash, all unique"                                               PASS
   "Array#gibbler, all unique"                                           PASS
   "Hash#gibbler, all unique"                                            PASS

 Gibbler::Digest                                                                

  All methods 
   "has short method"                                                    PASS
   "can Gibbler::Digest#short"                                           PASS
   "==  is strict  (only exact matches)"                                 PASS
   "=== is relaxed (allows partial matches)"                             PASS
   "supports base36 output"                                              PASS
   "base36 works on digests too"                                         PASS
   "base36 digests can be short too"                                     PASS

  Backwards compatability 
   "Gibbler Objects have gibbler_cache method"                           PASS
   "Gibbler Objects have __gibbler_cache method"                         PASS
   "__gibbler_cache returns the same value as gibbler_cache"             PASS

 Aliases                                                                        

  Gibbler::Object Aliases 
   "has digest"                                                          PASS
   "has digest_cache"                                                    PASS
   "has changed?"                                                        PASS

  Gibbler::History Aliases 
   "can convert short digest into long"                                  PASS
   "can return most recent stamp"                                        PASS
   "can return history"                                                  PASS
   "can return history (short)"                                          PASS

 117 of 123 dreams came true (95%) 
flame@yamato gibbler % ruby19 -S sergeant
 History                                                                        

  Basics 
   "can convert short digest into long"                                  PASS
   "can return most recent stamp"                                        PASS
   "can return history"                                                  PASS
   "can return history (short)"                                          PASS

  Hash History 
   "Setup Hash class"                                                    PASS
   "doesn't reveal self.__gibbler_history instance variable"             PASS
   "can take a Hash snapshot"                                            PASS
   "return a Hash history"                                               PASS
   "can revert Hash"                                                     PASS
   "knows a valid gibble"                                                PASS
   "knows an invalid gibble"                                             PASS
   "can revert to any valid gibble"                                      PASS
   "revert does nothing if digest is the same as current one"            PASS
   "can revert using short gibble"                                       PASS

  String History 
   "Setup String class"                                                  PASS
   "can take a String snapshot"                                          PASS
   "return a String history"                                             PASS
   "can revert String"                                                   PASS

  Arbitrary Object History 
   "Setup String class"                                                  PASS
   "can take a FullHouse snapshot"                                       PASS
   "return a FullHouse history"                                          FAIL 
   "can revert FullHouse"                                                PASS

  "return a FullHouse history"                                           1/1   
      failed: ["4192d4cb59975813f117a51dcd4454ac16df6703", "05219bdee8ec6300b579f2ba8ce55d851d10928b"] == ["4192d4cb59975813f117a51dcd4454ac16df6703", "2c6957aa1e734d2a3a71caf569a7461a3bf26f11"]
       drill: ["4192d4cb59975813f117a51dcd4454ac16df6703", "05219bdee8ec6300b579f2ba8ce55d851d10928b"]
       dream: ["4192d4cb59975813f117a51dcd4454ac16df6703", "2c6957aa1e734d2a3a71caf569a7461a3bf26f11"]


  Exceptions 
   "raises exception when reverting to unknown gibble"                   PASS
   "raises exception when reverting and there's no history"              PASS
   "raises exception when reverting an unsupported object"               PASS

  Array History 
   "Setup Array class"                                                   PASS
   "can take a Array snapshot"                                           PASS
   "return an Array history"                                             PASS
   "can revert Array"                                                    PASS

 Gibbler Gazette                                                                

  URI object tryouts 
   "URI::HTTP can gibbler"                                               PASS
   "URI::HTTPS can gibbler"                                              PASS
   "URI::HTTP is trailing slash sensitive"                               PASS
   "URI::Generic can gibbler"                                            PASS
   "URI::FTP can gibbler"                                                PASS

  Time tryouts 
   "Date instance can gibbler"                                           PASS
   "Time instance can gibbler"                                           PASS
   "Time instance can gibbler with single digit values"                  PASS
   "DateTime instance can gibbler"                                       PASS
   "Time digest is based on UTC"                                         PASS
   "DateTime digest is based on UTC"                                     PASS

  Basic syntax with SHA256 
   "A Symbol can gibbler"                                                PASS
   "Class can gibbler"                                                   PASS
   "TrueClass can gibbler"                                               PASS
   "Empty Hash instance"                                                 PASS

  Extended object tryouts 
   "true can gibbler"                                                    PASS
   "false can gibbler"                                                   PASS
   "TrueClass can gibbler"                                               PASS
   "FalseClass can gibbler"                                              PASS
   "Class can gibbler"                                                   PASS
   "Object can gibbler"                                                  PASS
   "Class instance can gibbler"                                          PASS
   "Module can gibbler"                                                  PASS
   "Module instance can gibbler"                                         PASS
   "Proc can gibbler"                                                    PASS
   "Range instance (..) can gibbler"                                     PASS
   "Range instance (...) can gibbler"                                    PASS
   "Range (..) doesn't equal range (...)"                                PASS
   "nil has a gibbler"                                                   PASS
   "Module can gibbler"                                                  PASS
   "Module instance can gibbler"                                         PASS
   "Class can gibbler"                                                   PASS

  Proc 
   "Proc.new can gibbler"                                                PASS
   "Proc can gibbler"                                                    PASS
   "proc can gibbler"                                                    PASS
   "lambda can gibbler"                                                  PASS
   "lambda gibbler is not aware of arity"                                PASS
   "proc gibbler is not aware of arity"                                  PASS
   "Proc gibbler is not aware of proc payload"                           PASS
   "MyProc has a different digest"                                       PASS

  Basic syntax with SHA1 
   "include Gibbler raises exception"                                    PASS
   "Symbol can gibbler"                                                  PASS
   "String can gibbler"                                                  PASS
   "String and Symbol return different digests"                          PASS
   "Class can gibbler"                                                   PASS
   "Empty Hash instance"                                                 PASS
   "Fixnum instance"                                                     PASS
   "Bignum instance"                                                     PASS
   "Populated Hash instance"                                             PASS
   "Empty Array instance"                                                PASS
   "Populated Array instance"                                            PASS
   "Knows when a Hash has not changed"                                   PASS
   "Knows when a Hash has changed"                                       PASS
   "Symbols digests don't cross streams"                                 PASS
   "String digests don't cross streams"                                  PASS
   "Symbol has list of attic vars"                                       PASS
   "String has list of attic vars"                                       FAIL 
   "Hash has list of attic vars"                                         FAIL 
   "Freezing an object will update the digest"                           PASS
   "works on arbitrary objects"                                          FAIL 
   "doesn't reveal @__gibbler_digest__ instance variable"                PASS
   "previous digest"                                                     PASS

  "String has list of attic vars"                                        1/3   
      failed: [:gibbler_cache, :__gibbler_history] == [:gibbler_cache]
       drill: [:gibbler_cache, :__gibbler_history]
       dream: [:gibbler_cache]


  "Hash has list of attic vars"                                          2/3   
      failed: [:gibbler_cache, :__gibbler_history] == [:gibbler_cache]
       drill: [:gibbler_cache, :__gibbler_history]
       dream: [:gibbler_cache]


  "works on arbitrary objects"                                           3/3   
      failed: #<FullHouse:0x0000000247bd18 @roles=[:jesse, :joey, :danny, :kimmy, :michelle, :dj, :stephanie]>.gibbler == "6ea546919dc4caa2bab69799b71d48810a1b48fa"
       drill: "fa5f741275b6b27932537e1946042b0286286e1d"
       dream: "6ea546919dc4caa2bab69799b71d48810a1b48fa"


  File object tryouts 
   "File can gibbler"                                                    FAIL 
   "Gibbler is different for each path"                                  FAIL 
   "TempFile can gibbler"                                                PASS
   "TempFile digests change"                                             PASS
   "File doesn't care about file contents"                               PASS

  "File can gibbler"                                                     1/2   
      failed: #<File:/media/repos/flame/ruby/gibbler/CHANGES.txt>.gibbler == "33027386bd95e91efc4711648d488519062d828f"
       drill: "d5b2b0ac570bf7ac3aa1ca7e3d905b325de31671"
       dream: "33027386bd95e91efc4711648d488519062d828f"


  "Gibbler is different for each path"                                   2/2   
      failed: #<File:/media/repos/flame/ruby/gibbler/README.rdoc>.gibbler == "4c131b7e5f9e7b841b4501d2d002785d3730ae19"
       drill: "6b84d8790e02fdea14dc46ef3f5fdcc1da6e392b"
       dream: "4c131b7e5f9e7b841b4501d2d002785d3730ae19"


 Mixins                                                                         

  String 
   "has String#clear"                                                    PASS

 Performance                                                                    

  Speed 
   "Setup variables"                                                     PASS
   "Array#hash"                                                          PASS
   "Array#gibbler"                                                       PASS
   "Hash#hash"                                                           PASS
   "Hash#gibbler"                                                        PASS

  Uniqueness 
   "Array#hash, all unique"                                              PASS
   "Hash#hash, all unique"                                               PASS
   "Array#gibbler, all unique"                                           PASS
   "Hash#gibbler, all unique"                                            PASS

 Gibbler::Digest                                                                

  All methods 
   "has short method"                                                    PASS
   "can Gibbler::Digest#short"                                           PASS
   "==  is strict  (only exact matches)"                                 PASS
   "=== is relaxed (allows partial matches)"                             PASS
   "supports base36 output"                                              PASS
   "base36 works on digests too"                                         PASS
   "base36 digests can be short too"                                     PASS

  Backwards compatability 
   "Gibbler Objects have gibbler_cache method"                           PASS
   "Gibbler Objects have __gibbler_cache method"                         PASS
   "__gibbler_cache returns the same value as gibbler_cache"             PASS

 Aliases                                                                        

  Gibbler::Object Aliases 
   "has digest"                                                          PASS
   "has digest_cache"                                                    PASS
   "has changed?"                                                        PASS

  Gibbler::History Aliases 
   "can convert short digest into long"                                  PASS
   "can return most recent stamp"                                        PASS
   "can return history"                                                  PASS
   "can return history (short)"                                          PASS

 117 of 123 dreams came true (95%)
@Flameeyes
Copy link
Author

This is much improved with 0.8.0 and latest git (as you fixed the path problem last night), what remains is:

"String has list of attic vars" 1/2
failed: [:gibbler_cache, :__gibbler_history] == [:gibbler_cache]
drill: [:gibbler_cache, :__gibbler_history]
dream: [:gibbler_cache]

"Hash has list of attic vars" 2/2
failed: [:gibbler_cache, :__gibbler_history] == [:gibbler_cache]
drill: [:gibbler_cache, :__gibbler_history]
dream: [:gibbler_cache]

And this applies on all the current implementations I have installed:
flame@yamato ~ % uname -a
Linux yamato.local 2.6.33.2 #29 SMP PREEMPT Fri Apr 2 12:29:07 CEST 2010 x86_64 Quad-Core AMD Opteron(tm) Processor 2350 AuthenticAMD GNU/Linux
flame@yamato ~ % ruby -v
ruby 1.8.7 (2010-01-10 patchlevel 249) [x86_64-linux]
flame@yamato ~ % ruby19 -v
ruby 1.9.1p376 (2009-12-07 revision 26041) [x86_64-linux]
flame@yamato ~ % jruby -v
jruby 1.4.0 (ruby 1.8.7 patchlevel 174) (2010-04-07 6586) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_19) [amd64-java]

Attic is installed: dev-ruby/attic-0.5.2

@delano
Copy link
Owner

delano commented Apr 11, 2010

Thanks for the detailed report.

I haven't been able to replicate the attic_vars fails though. The __gibbler_history variable should only appear when lib/gibbler/history.rb is required (it's not by default). Is this report from a modified gibbler or directly from a clean checkout?

@Flameeyes
Copy link
Author

Clean checkout, but I have to say I have all the rudy dependencies installed on the system at runtime, not sure if that matters much.

@delano
Copy link
Owner

delano commented Apr 11, 2010

Ah yeah, I require gibbler/history somewhere. I'll update the tryout to explicitly require it at test time.

I actually just pushed a release before I saw your message so I'll include the test fix in 0.8.2.

@delano
Copy link
Owner

delano commented Apr 29, 2010

Hey just as an FYI, I took a look at these tests and I confirmed that the issue was just that gibbler/history is required elsewhere. The easiest fix was just to comment them out b/c these tests weren't so helpful anyway.

The fix will be in the 0.8.2 release (today or tomorrow).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delano @Flameeyes