Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rye::Set should not pass bad opts to Rye::Box #11

Open
rlister opened this issue Aug 18, 2011 · 1 comment
Open

Rye::Set should not pass bad opts to Rye::Box #11

rlister opened this issue Aug 18, 2011 · 1 comment
Assignees

Comments

@rlister
Copy link

rlister commented Aug 18, 2011

Rye::Box does a great job of setting options, in my case getting user from .ssh_config. However, creating a Set and adding boxes with String args fails in this case:

r = Rye::Set.new
r.add_box('host1', 'host2')

This uses :user => Rye.sysinfo.user, as set in Rye::Set::initialize. I have to use either:

r = Rye::Set(:user => 'foobar')
r.add_box %w(host1 host2)

or create Boxes explicitly:

r.add_box %w(host1 host2).map{|b| Rye::Box.new b}

Can Set just pass opts straight through to Box without merging some limited defaults?

@delano
Copy link
Owner

delano commented Aug 18, 2011

Ya, that seems reasonable. I'll look into it but I'm pretty swamped right now so it could take a while. If you'd like to submit a pull request with the changes, I could create a release pretty quick.

@ghost ghost assigned delano Jul 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants