Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"System cannot find the path specified" error at Rye::Box.new() on Windows #70

Open
zinga666 opened this issue Aug 30, 2017 · 2 comments

Comments

@zinga666
Copy link

When using Rye on Windows (which works great by the way!) there's always an error message System cannot find the path specified when initializing a Rye::Box.

I guess this is because of

@rye_stty_save = `stty -g 2>/dev/null`.chomp rescue nil

which could probably be changed to something like

@rye_stty_save = `stty -g 2>/dev/null`.chomp unless Rye.sysinfo.os == :windows rescue nil

in Rye::Box (and also in Rye::Hop I guess).

I didn't make a PR because it seems like there is already a pending PR #56 which also works on that code (on a slightly different matter) and recently there seems to be no more activity in the repo. I'd be happy to make one though if there's still interest...

@delano
Copy link
Owner

delano commented Aug 30, 2017

Thanks for bringing this back on the radar.

Can you check if the change on that PR works for you? Usingif STDIN.tty? rescue nil instead of checking the OS.

@zinga666
Copy link
Author

Hey, thanks for the reply!

Can you check if the change on that PR works for you? Usingif STDIN.tty? rescue nil instead of checking the OS.

Oh, forgot to mention that I already did that - and well, no, it doesn't work because STDIN.tty? returns true on Windows as well.

So, when doing both checks this might be a little bit much/rather unreadable for a one liner... ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants