Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desi_zcatalog cannot be run on quickquasars mocks after refactoring #2140

Open
p-slash opened this issue Nov 6, 2023 · 2 comments
Open

desi_zcatalog cannot be run on quickquasars mocks after refactoring #2140

p-slash opened this issue Nov 6, 2023 · 2 comments

Comments

@p-slash
Copy link

p-slash commented Nov 6, 2023

During the refactoring --prefix option seems to be dropped. Lya WG group used this option to run desi_zcatalog script on quickquasars mocks (see issue #1370 by @alxogm ). Maybe the script got too complicated to support this argument, @sbailey ?

Workaround:

  1. Do not load the main branch (tested by Andrei): source /global/common/software/desi/desi_environment.sh 23.1
    detail: edited by Stephen to explicitly load environment 23.1 rather than the default, which will change in the future)
  2. People can use my simple script to combine Healpix mock zbest catalogs. https://github.com/p-slash/desi-y1-p1d/blob/5402816c4fc7c23bf120149ad3591185d2d6fa86/src/desi_y1_p1d/qq_zcatalog.py
@alxogm
Copy link

alxogm commented Nov 7, 2023

Oh, I was not aware there was a refactoring of desi_zcatalog. Lets see if @sbailey confirms if this script will not continue to support other prefix's, in which case we can add @p-slash script, or a similar one, maybe to desisim or igmhub for further use of the LyaWG. or its just a matter of including the feature in the new version.

@sbailey
Copy link
Contributor

sbailey commented Nov 7, 2023

Apologies for breaking the --prefix option. Supporting it in the refactor was getting complicated, though from looking at the code again I don't remember why. I thought I was dropping a leftover option from pre-data days, not realizing it was still in use.

Two requests:

  1. please post an example directory at NERSC and what --prefix option previously would have worked but is now broken (for testing that the right feature is actually being re-implemented usefully)
  2. does anyone in the LyA WG have time to try to fix this? Normally "I broke it I should fix it", but that might take longer for me to find the time than if someone else could jump in to help (with my thanks...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants