Working on upgrading compose-settings. #1420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV-GH
reviewed
Mar 2, 2024
| @@ -33,10 +32,10 @@ import androidx.compose.ui.res.stringResource | |||
| import androidx.compose.ui.text.input.KeyboardCapitalization | |||
| import androidx.compose.ui.text.input.KeyboardType | |||
| import androidx.compose.ui.text.input.TextFieldValue | |||
| import com.alorma.compose.settings.storage.base.rememberBooleanSettingState | |||
| import com.alorma.compose.settings.storage.base.rememberIntSettingState | |||
| import com.alorma.compose.settings.storage.disk.rememberBooleanSettingState | |||
There was a problem hiding this comment.
Does this persist the settings for us?
This shouldn't be done for account right? These settings are different per account
There was a problem hiding this comment.
We really don't need to remember anything, since the remembering is done in the DB. But I'm not sure exactly how to integrate that with alorma as inputs. I'll see if it can be done without these.
There was a problem hiding this comment.
The previous remembers aren't for persisting, just how state works in compose https://developer.android.com/jetpack/compose/state
There was a problem hiding this comment.
alorma's compose setting I mean, supposedly its saveable and restoring from disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.