Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non mirrored only votes swipe action #1421

Merged
merged 6 commits into from Mar 8, 2024
Merged

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Mar 3, 2024

  • Add non mirrored only votes swipe action
  • Decrease sensitivity slightly, not sure how to reduce the vertical sensitivity though
  • Also changed default to disabled (This feature is not stable enough)

Fix #1416

@MV-GH MV-GH requested a review from dessalines as a code owner March 3, 2024 01:04
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think one more issue with that ticket, is that every place we use the word swipe right, it actually means swipe left . But feel free to merge when you see fit.

@@ -41,11 +41,11 @@ val APP_SETTINGS_DEFAULT =
showPostLinkPreviews = true,
postActionBarMode = 0,
autoPlayGifs = false,
swipeToActionPreset = SwipeToActionPreset.DEFAULT.ordinal,
swipeToActionPreset = SwipeToActionPreset.DISABLED.ordinal,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, disabled default is probably best.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Mar 5, 2024

@Snow4DV Was it intended to work as the direction mention in the text you had written it. Or was the text wrong? I think most users want these actions to be mirrored?

@Snow4DV
Copy link
Contributor

Snow4DV commented Mar 5, 2024

@Snow4DV Was it intended to work as the direction mention in the text you had written it. Or was the text wrong? I think most users want these actions to be mirrored?

I guess I just made the whole jerboa community aware of me never using tinder lol :DD

Defi
nitely a mistake on my side - good fix!

And I too agree on disabling it by default. Default behavior of swipetodismiss turned out to be pretty bad in terms of nested scrolling. I tried improving it but it basically means rewriting it from scratch and I'm too low on time atm (hope google would fix swipetodismiss rather sooner than later)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't really fix the issue, I tried

Copy link
Collaborator Author

@MV-GH MV-GH Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it doesn't ;/

Maybe messing with the dampner options?

Edit nvm this seems only for the color animation

Copy link
Contributor

@Snow4DV Snow4DV Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it doesn't ;/

Maybe messing with the dampner options?

I also tried this workaround: https://stackoverflow.com/a/76604939 (change velocity threshold of anchoreddraggable) modifying stuff using java's reflections and it behaves the same sadly :(

I'll try digging deeper when i have time. There's resistance param in old material (not material3) swipetodismiss. It might improve the situation

@dessalines
Copy link
Member

I tried improving it but it basically means rewriting it from scratch and I'm too low on time atm (hope google would fix swipetodismiss rather sooner than later)

That'd be helpful, but no rush. Whenever you have the time :)

@dessalines dessalines merged commit ee790ca into LemmyNet:main Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe-to-vote gestures are backwards ("swipe right" to upvote)
3 participants