Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More horizontal line fixes. #1423

Merged
merged 4 commits into from Mar 8, 2024
Merged

More horizontal line fixes. #1423

merged 4 commits into from Mar 8, 2024

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Mar 4, 2024

I removed a few more pointless horizontal lines, and it does look much cleaner IMO:

Screenrecorder-2024-03-04-10-04-47-7.mp4

@dessalines dessalines marked this pull request as ready for review March 4, 2024 15:07
@dessalines dessalines requested a review from MV-GH as a code owner March 4, 2024 15:07
@MV-GH
Copy link
Collaborator

MV-GH commented Mar 4, 2024

Hmm i think the divide between comments and post in postview could still use a horizontal divider?

@MV-GH
Copy link
Collaborator

MV-GH commented Mar 5, 2024

Boost doesn't go that far but other G apps do seem to go in this direction too. Does still feel unnatural to me but I'll probably get used to it.

@dessalines
Copy link
Member Author

Hmm i think the divide between comments and post in postview could still use a horizontal divider?

I'll add this shortly.

@dessalines dessalines marked this pull request as draft March 5, 2024 22:28
@dessalines dessalines marked this pull request as ready for review March 5, 2024 22:33
@dessalines dessalines merged commit 555abbf into main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants