Fix issues caused by edge to edge #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV-GH
commented
Mar 10, 2024
| @@ -238,7 +236,7 @@ fun BottomNavActivity( | |||
| ) | |||
| } | |||
| }, | |||
| ) { _ -> | |||
| ) { padding -> | |||
There was a problem hiding this comment.
This change was need to propagate the padding of the navigation bar (ours) else content hides behind it. We can't use the previous approach that applies it to the navhost, that causes weird issues
MV-GH
commented
Mar 10, 2024
| @@ -308,6 +311,7 @@ fun BottomNavActivity( | |||
| siteViewModel = siteViewModel, | |||
| drawerState = drawerState, | |||
| blurNSFW = appSettings.blurNSFW.toEnum(), | |||
| padding = padding, | |||
There was a problem hiding this comment.
Bit annoying, at some point I'll see if I can lift this all out of this nested navhost and just have a single one
MV-GH
commented
Mar 10, 2024
| @@ -2,6 +2,7 @@ | |||
| <resources> | |||
|
|
|||
| <style name="Theme.Jerboa" parent="Theme.AppCompat.NoActionBar"> | |||
| <item name="android:windowTranslucentStatus">true</item> | |||
There was a problem hiding this comment.
If i don't do this, it applies the status bar padding twice, this could have also been due to the nested scaffold.
MV-GH
commented
Mar 10, 2024
| val baseModifier = if (padding == null) { | ||
| Modifier | ||
| } else { | ||
| // https://issuetracker.google.com/issues/249727298 |
There was a problem hiding this comment.
When using edge to edge, it also applies the navigationbar padding above the IME
dessalines
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess we didn't need edge to edge. Causes too much problems atm
Fixes #1436
Fixes #1441
Fixes #1439
Fixes #1437