Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some 74xx parts don't load #184

Open
2e0byo opened this issue May 13, 2023 · 1 comment
Open

Some 74xx parts don't load #184

2e0byo opened this issue May 13, 2023 · 1 comment
Labels

Comments

@2e0byo
Copy link
Contributor

2e0byo commented May 13, 2023

Describe the bug
Some parts in the 74xx library (6.0.11) load fine. Others refuse to load.

Of those which do load I'm surprised to see duplicated pins. Does SKIDL handle inherited parts?

To Reproduce

from skidl import Part
p = Part("74xx", "74LS03")
print(p) # prints part, albeit with duplicate pins
assert len p[6] == 1, "Duplicate pins!"
p = Part("74xx", "74LS04")
assert len p.pins, "No pins at all!"
print(p)

Expected behavior

  • all parts in the library should load
  • only one instance of each pin should exist.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS Linux/Arch
  • Python 3.11
  • SKIDL 1.1.0
@2e0byo 2e0byo added the bug label May 13, 2023
@2e0byo
Copy link
Contributor Author

2e0byo commented May 13, 2023

kicad 5 libraries (5.1.12) work. We need some unit-tests methinks. I'll see if I've got some space to write any in a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant