Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact port of the new react-transition-group ? #8

Open
tzvc opened this issue May 9, 2018 · 6 comments
Open

Preact port of the new react-transition-group ? #8

tzvc opened this issue May 9, 2018 · 6 comments

Comments

@tzvc
Copy link

tzvc commented May 9, 2018

Hi there, love what you are doing with Preact, it's awesome ! ;)

I've been searching for the equivalent of the new https://github.com/reactjs/react-transition-group in Preact.

Is this what this is supposed to be ? If yes what is the equivalent of the CSSTransition component ?

Thanks !

@vinaybedre
Copy link

As I see, there is no CSSTransition class exported in preact-transition-group

@andrewiggins
Copy link
Contributor

@theochampion @vinaybedre FYI, I've begun a rewrite of this package based on the new v2 react-transition-group which includes the CSSTransition component. A PR should be out in the (hopefully) near future.

@lchimaru
Copy link

@andrewiggins any progress?

@andrewiggins
Copy link
Contributor

Yes! I've gotten a good amount of the work done in my andrewiggins/preact-transition-group refork-v2 branch. Still working through fixing all the tests.

@ghost
Copy link

ghost commented Aug 16, 2019

@andrewiggins any chance you can port this over to preact-x? thanks!

@lohfu
Copy link

lohfu commented Nov 30, 2019

@andrewiggins i have converted the latest react-transition-group to work with preact X. it wasn't that much work, but i've struggled with a couple of the tests. 13 out of 54 still fail. it's fully functional now as far as i can tell, but i think i'm gonna need some help bringing it over the finish line. if you guys are interested that is.

i've pushed my changes to the preact branch in a forked repo, https://github.com/lohfu/react-transition-group/tree/preact

regarding the tests, i think most of the problems stem from inconsistencies in the react and preact adapters for enzyme, but i'm not 100% sure. i bet if you have a look you'll solve most of them in a jiffy.

EDIT
the only test file i have not touched yet is, https://github.com/lohfu/react-transition-group/blob/preact/test/CSSTransitionGroup-test.js. i let it be because almost all tests depended on the render function returning returning a VNode. i have never used enzyme before this, nor do i know any of the inner workings of preact or react so i felt it was best to leave it completely untouched so someone with more skillz can see what the react peeps intended the tests to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants