Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the incompatibility problem for range separated input #1332

Closed
wants to merge 1 commit into from

Conversation

aradi
Copy link
Member

@aradi aradi commented Oct 9, 2023

Closes #1331

However, #1223 might fix this (as the input was changed there), so do not merge it yet.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7cbd788) 69.81% compared to head (763b3be) 69.81%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   69.81%   69.81%           
=======================================
  Files         227      227           
  Lines       42543    42541    -2     
=======================================
  Hits        29700    29700           
+ Misses      12843    12841    -2     
Files Coverage Δ
src/dftbp/dftbplus/parser.F90 77.79% <87.50%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhourahine
Copy link
Member

@aradi Is it worth merging for the 23.2 release then reverting for the hybrids merge prior to 24.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range separated input can not handle None {}
2 participants