Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isWeekend is country specific #1100

Closed
amitaibu opened this issue Oct 2, 2021 · 2 comments
Closed

isWeekend is country specific #1100

amitaibu opened this issue Oct 2, 2021 · 2 comments

Comments

@amitaibu
Copy link
Collaborator

amitaibu commented Oct 2, 2021

A bit nitpick-y, but I'm living in Israel and our weekend is actually on Friday and Saturday. Sunday is a working day (which makes it lovely to have one day for silence, when most of our clients are at their weekend 馃槃 )

So maybe isWeekend should be removed from IHP's core, just to make sure we don't have an incorrect function?
@mpscholten
Copy link
Member

thanks for pointing this out! Wasn't aware about this. Love that you have sunday for coding :)

In generally I'm fine with having isWeekend as it is as long as the documentation makes it clear that in IHP-terms weekend means Saturday + Sunday. Most users of IHP are in the US and Norway, so for most users it's the most natural choice.

I was looking into how other frameworks have dealt with this, and most are doing it the same.

@amitaibu
Copy link
Collaborator Author

amitaibu commented Oct 3, 2021

Alright, sounds ok.

Most users of IHP are in the US and Norway,

For now there's also at least one Israeli user 馃槈

@amitaibu amitaibu closed this as completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amitaibu @mpscholten