Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add commentary on median otsu tutorial/change default parameters #3124

Open
alexrockhill opened this issue Mar 15, 2024 · 8 comments
Open

Comments

@alexrockhill
Copy link
Contributor

Using dipy_median_otsu CLI without flags tends to give holes in the mask for multiple people. Per @skoudoro a discussion of this in the tutorial would help (to use median_radius=4 and numpass=4 ).

@pjsjongsung
Copy link
Contributor

If holes are the main problem, we could move the correct_minor_errors from dipy.nn.utils to segment utils and use that. The function is intended to exactly do that and remove any non connected masks

@skoudoro
Copy link
Member

Thanks @pjsjongsung, we might need to rename this function correct_minor_errors. Hard to guess, it is not very explicit. is this function correcting only this "minor errors" or there are other errors ?

@pjsjongsung
Copy link
Contributor

It only corrects for the two mentioned errors: holes and non connected masks. We could change it to something like correct_mask?

@skoudoro
Copy link
Member

We could change it to something like correct_mask?

fill_holes() ?

@pjsjongsung
Copy link
Contributor

But it does also remove non connected masks. fill_holes_select_largest sounds too long though.

@alexrockhill
Copy link
Contributor Author

You could also split it into fill_holes and remove_islands or some such since those don't necessarily need to be paired.

@pjsjongsung
Copy link
Contributor

That does sound reasonable. I'll go ahead and do that.

@pjsjongsung
Copy link
Contributor

Just realized the current implementation is not separable. Will go with remove_holes_and_islands. I guess the name can be long since it will mostly be an internal function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants