DOC: Fixes the AFQ tract profile tutorial. #3178
Conversation
This also adds the capability to download AFQ derivatives for all of the HBN subjects from the FCP INDI bucket where those are stored as part of the HBN POD2 study.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 83.65% 83.61% -0.05%
==========================================
Files 153 153
Lines 21272 21285 +13
Branches 3434 3438 +4
==========================================
+ Hits 17796 17797 +1
- Misses 2618 2630 +12
Partials 858 858
|
There was a problem hiding this comment.
Hi @arokem,
Thank you for this.
No sure the reason, but the download was quite long and TQDM did not show up. So I did not know if the terminal was freezing or something was happening.
Can you look at this, and make sure that TQDM shows up. Even when the data are already in place, we do not have any information like the other fetcher.
Otherwise, Can you tell me if this result looks correct to you?
Apart from this 2 points, it looks good to go.
|
The result looks correct. I'll look into the tqdm issue and report back. |
dipy/data/fetcher.py
Outdated
| return data_files | ||
|
|
||
|
|
||
| def fetch_hbn(subjects, path=None, include_afq=False): |
There was a problem hiding this comment.
Also, We start to introduce keyword-only arguments in the codebase.
can you replace this by def fetch_hbn(subjects, *, path=None, include_afq=False):
There was a problem hiding this comment.
Changed in 5123bcd. Just noting that I've noticed that this transition is breaking downstream code. I guess folks will have to update all their calls if they want to update dipy.
There was a problem hiding this comment.
if it breaks, put it back as it was before, I plan a decorator to handle this and warn user for the whole codebase.
|
Hi @arokem,
Do you have an update on this ? |
This also adds the capability to download AFQ derivatives for all of the HBN subjects from the FCP INDI bucket where those are stored as part of the HBN POD2 study.
Addresses #3175, hopefully once and for all.