Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Refreshing Iframe on page #188

Open
vaibhavbhanushali opened this issue Jun 21, 2016 · 11 comments
Open

Automatic Refreshing Iframe on page #188

vaibhavbhanushali opened this issue Jun 21, 2016 · 11 comments

Comments

@vaibhavbhanushali
Copy link

Whenever i try to open Custombox, the iframe on my page (not in Custombox modal content), gets automatically refreshed.

@dixso
Copy link
Owner

dixso commented Jun 21, 2016

Hi,
Try this: #183

@vaibhavbhanushali
Copy link
Author

Well, it prevents it from opening, but on close function, still the iframe reloads.
Any suggestions?

@Teppichratte
Copy link

He told me in an email he'll start working on a new version from this week on and fix this issue. Hopefully he can solve it soon as our website is almost unuseable while this bug hasnt been solved.

@vaibhavbhanushali
Copy link
Author

vaibhavbhanushali commented Jul 31, 2016

Hello @Teppichratte
I have managed to fix my issue on my own.
Also use Custombox.set({ autobuild: true }); at top of the page.
(Downside: your page body content will be wrapped inside a div,though it doesn't matters much),
but this will work, until he releases new version
custombox.js.zip

@Teppichratte
Copy link

Hi @vaibhavbhanushali, thank you for your effort.
I will try it next week but I hope he will publish a new version until next week.
Greetz

@dixso dixso closed this as completed Oct 1, 2016
@Teppichratte
Copy link

Hi @dixso, your bugfix is still not fixing all issues.

It got better but here you can see the iframe of a youtube video getting refreshed each time a modal window gets opened or closed. I'm using the latest version of your custombox:
video.zip

@Teppichratte
Copy link

@dixso Any news on this?

@dixso
Copy link
Owner

dixso commented Aug 21, 2017

Hi @Teppichratte ,
I'm on holidays, I'll review it when I return.

@dixso dixso reopened this Aug 21, 2017
@Teppichratte
Copy link

Teppichratte commented Aug 30, 2017

For your information:
Everytime the modal windows gets opened OR closed the iframe (e. g. youtube video) in the background gets refreshed/reloaded.

This happens when you use the following properties:

			target: "#modal_window",
			effect: "blur",
			open: function() {},
			escKey: false,
			speed: 200,
			overlaySpeed: 200,
			overlayColor: "#eeeeee",
			overlayOpacity: 0.6,
			speedIn: 200,
			speedOut: 0

If you remove "speedIn" and "speedOut" then only the first opening (NOT the closing) refreshs/reloads the iframe in the background. I have removed the usage of speedIn and speedOut but still the first refreshing/reloading of the youtube iframe is annoying.

Can you tell me, when you are going to fix this?

@Teppichratte
Copy link

Now I've noticed that when I change the effect from "blur" to "scale" the iframe doesn't get refreshed/reloaded in the background so it must be a thing with the blur effect.

@mrov
Copy link

mrov commented Oct 10, 2017

Agreed with @Teppichratte, maybe its a blur problem im using it right now and reloads, if i use fadein everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants