Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of semicolon less js #345

Closed
joshcartme opened this issue Dec 12, 2012 · 2 comments
Closed

Incorrect handling of semicolon less js #345

joshcartme opened this issue Dec 12, 2012 · 2 comments

Comments

@joshcartme
Copy link

I ran into the issue described here:
twbs/bootstrap#3057

  clearMenus()
  !isActive && $parent.toggleClass('open')

That code, which works uncompressed breaks when compressed because django-compressor removes the line break after clearMenus()

The code, which is from Twitter Bootstrap bootstrap-dropdown.js has since been updated to work in compressor like django-compressor, but it still would be a good idea to have django-compressor correctly handle this situation in case other code uses the convention.

@diox
Copy link
Member

diox commented Dec 12, 2012

Hi,
Can you test with develop version ? It should have been fixed by 48d9e4b

@joshcartme
Copy link
Author

You're right, it does work with the dev version. I guess I should have tried that before posting =/

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants