Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help users by adding type annotations / type stubs for mypy #753

Open
MartinThoma opened this issue Jul 5, 2021 · 2 comments
Open

Help users by adding type annotations / type stubs for mypy #753

MartinThoma opened this issue Jul 5, 2021 · 2 comments

Comments

@MartinThoma
Copy link

Hiho :-)

What do you think about adding type annotations / type stubs so that users can check their code better with mypy?

If you want to read more about it, I've written an article about type annotations in mypy. Let me know if you have questions about it.

As Python 3.5 is the oldest version you support, adding type annotations to function signatures would work: https://docs.python.org/3.5/library/typing.html

@ad-m
Copy link
Member

ad-m commented Jul 5, 2021

I am in favor of adding typing as long as it does not break backwards compatibility. I also see no problem that backward compatibility requires automated transpilation before release.

However - as a maintaner - I do not see the project's own resources to make such changes. Note that I am currently not experienced with types in Python.

If you create a pull request - we can gradually work on its release.

@michael-k
Copy link
Collaborator

I don't have a clear opinion. I like type annotations and use them everywhere else but

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants