Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殰 Convert sitemaps from a Django templates #1146

Closed
4 tasks done
jefftriplett opened this issue Apr 27, 2024 · 3 comments 路 Fixed by #1147
Closed
4 tasks done

馃殰 Convert sitemaps from a Django templates #1146

jefftriplett opened this issue Apr 27, 2024 · 3 comments 路 Fixed by #1147

Comments

@jefftriplett
Copy link
Contributor

jefftriplett commented Apr 27, 2024 •
edited

I noticed tonight that our sitemap.xml is a home rolled view + template. We should port this over to django.contrib.sitemaps and ideally use a sitemap index to help cut down on the overall rendering time.

  • Static pages
  • Packages
  • Grids
  • Blog

See template: https://github.com/djangopackages/djangopackages/blob/main/templates/sitemap.xml#L1-L24
@saadmk11 saadmk11 mentioned this issue Apr 28, 2024
Merged
@jefftriplett
Copy link
Contributor Author

@saadmk11 great work. Here's it working in production: https://djangopackages.org/sitemap.xml

@saadmk11
Copy link
Member

@saadmk11 great work. Here's it working in production: https://djangopackages.org/sitemap.xml

Awesome 馃嵒

@jefftriplett
Copy link
Contributor Author

@saadmk11 I added it the changelog.

https://djangopackages.org/changelog/2024-04-28-revamping-sitemap-generation-on-django-packages/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Sitemaps to Django Sitemap Framework saadmk11/djangopackages
2 participants
@jefftriplett @saadmk11