Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up typeystem query type method #201

Open
jcklie opened this issue Aug 25, 2021 · 2 comments
Open

Clean up typeystem query type method #201

jcklie opened this issue Aug 25, 2021 · 2 comments
Assignees
Milestone

Comments

@jcklie
Copy link
Collaborator

jcklie commented Aug 25, 2021

Is your feature request related to a problem? Please describe.
Right now, we have methods for checking type info like is_instance in three places, standalone functions, on Type and on Typesystem. It would be nice to unify them somehow if that makes sense.

@jcklie jcklie added this to the 0.6.0 milestone Aug 25, 2021
@jcklie jcklie self-assigned this Aug 25, 2021
@reckart
Copy link
Member

reckart commented Aug 25, 2021

Any specific idea how to unify them?

@jcklie
Copy link
Collaborator Author

jcklie commented Aug 25, 2021

Maybe only put them on the type or remove them atleast from the type system. If one adds a new function like these, it needs to be added in 3 places right now to adhere to the existing ones.

@reckart reckart modified the milestones: 0.6.0, 0.7.0 Sep 27, 2021
@reckart reckart modified the milestones: 0.7.0, Backlog Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants