Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold is minimum rather than exact. #21

Open
trans opened this issue Jan 15, 2014 · 2 comments
Open

Threshold is minimum rather than exact. #21

trans opened this issue Jan 15, 2014 · 2 comments

Comments

@trans
Copy link
Contributor

trans commented Jan 15, 2014

I am not sure why Yardstick would exit non-zero if coverage is above the set threshold, i.e. I don't know why any one would want it to be "exact" (for anything below 100%).

@dkubb
Copy link
Owner

dkubb commented Jan 16, 2014

@trans my rationale behind using an exact threshold is that if it changes, I usually want to know. If it improves, I want to raise the bar so that if my coverage drops I know about it right away. If it drops, then I know I'm letting things slide and I need to bring it back up.

I can understand that other people have different workflows. I wonder if perhaps having 3 flags:

  • minimum_threshold
  • maximum_threshold
  • threshold

Setting minimum_threshold would set the lower bounds, and maximum_threshold would set the upper bounds. Setting the threshold would set the first two flags, effectively making it so that the threshold needs to be an exact match, like it is now.

@trans
Copy link
Contributor Author

trans commented Jan 19, 2014

I wonder, could it store the previous coverage score and thus be able to report changes between runs? Then it could simply return non-zero status if coverage goes down instead of up (or equal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants