Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: do not leak image names that use secrets in github comments #6

Open
pozsa opened this issue Jul 12, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pozsa
Copy link

pozsa commented Jul 12, 2023

If the image uses a secret the value of the secret is leaked in the github comment.

In the example image below the image reference leaks the value of secrets (if they are used for the image name).
In case a secret is used as part of the image name the image reference should display *** for the secrets instead of leaking them.

some examples: ***/scout-demo-service:main, docker/scout-demo-service:***, ***/***:latest

image

@pozsa pozsa changed the title feature request: do not leak image names in github comments that use secrets feature request: do not leak image names that use secrets in github comments Jul 12, 2023
@mcapell mcapell self-assigned this Jul 12, 2023
@mcapell
Copy link
Contributor

mcapell commented Jul 12, 2023

Thank you for reporting this @pozsa, we will have a look at this

@cdupuis cdupuis added the enhancement New feature or request label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants